I disabled contact list tests when porting to 1.0 because they all still used contact list channels and I couldn't be bothered updating them at the time. haze stole its tests from gabble. They might already be updated in gabble. Either way, we should reinstate the tests at some point.
*** Bug 69433 has been marked as a duplicate of this bug. ***
Created attachment 86380 [details] [review] 01/16] sync constants.py from Gabble
Created attachment 86381 [details] [review] 02/16] sync servicetest.py from Gabble
Created attachment 86382 [details] [review] 03/16] sync gabbletest.py from Gabble
Created attachment 86383 [details] [review] 04/16] Use get_contact_handle_sync, get_contact_handles_sync Telepathy 1.0 won't have RequestHandles.
Created attachment 86384 [details] [review] 05/16] Don't test NewChannel lso use assertEquals(), etc., on the lines I'm touching anyway. Just remove initiate.py: the whole point of that test is to exercise an obsolete API. The modern form of the initiation part is tested by initiate-requestotron.py and the text bits are tested by test-text.py.
Created attachment 86385 [details] [review] 06/16] tests: use more constants, reduce hard-coding of o.fd.T
Created attachment 86386 [details] [review] 07/16] Fix more uses of RequestHandles
Created attachment 86387 [details] [review] 08/16] Use inspect_contacts_sync instead of InspectHandles
Created attachment 86388 [details] [review] 09/16] initial-roster test: convert to ContactList, ContactGroups
Created attachment 86389 [details] [review] 10/16] haze_contact_list_set_contact_groups_async: fix sense of test We want to remove the buddy from every group *not* listed in the argument.
Created attachment 86390 [details] [review] 11/16] roster/groups.py: convert to ContactGroups As a side-effect, this adds proper test coverage for SetGroupMembers and SetContactGroups.
Created attachment 86391 [details] [review] 12/16] roster/publish.py: convert to ContactList
Created attachment 86392 [details] [review] 13/16] roster/subscribe.py: convert to ContactList, ContactGroups
Created attachment 86393 [details] [review] 14/16] roster/remove-from-rp-subscribe.py: convert to Conn.I.ContactList
Created attachment 86394 [details] [review] 15/16] Remove unused function close_all_groups()
Created attachment 86395 [details] [review] 16/16] tests: stop calling RequestChannel
Comment on attachment 86380 [details] [review] 01/16] sync constants.py from Gabble Review of attachment 86380 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86381 [details] [review] 02/16] sync servicetest.py from Gabble Review of attachment 86381 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86382 [details] [review] 03/16] sync gabbletest.py from Gabble Review of attachment 86382 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86383 [details] [review] 04/16] Use get_contact_handle_sync, get_contact_handles_sync Review of attachment 86383 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86384 [details] [review] 05/16] Don't test NewChannel Review of attachment 86384 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86385 [details] [review] 06/16] tests: use more constants, reduce hard-coding of o.fd.T Review of attachment 86385 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86386 [details] [review] 07/16] Fix more uses of RequestHandles Review of attachment 86386 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86387 [details] [review] 08/16] Use inspect_contacts_sync instead of InspectHandles Review of attachment 86387 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86388 [details] [review] 09/16] initial-roster test: convert to ContactList, ContactGroups Review of attachment 86388 [details] [review]: ----------------------------------------------------------------- ++ ::: tests/twisted/constants.py @@ +188,5 @@ > ATTR_CONTACT_CAPABILITIES = CONN_IFACE_CONTACT_CAPS + '/capabilities' > ATTR_PRESENCE = CONN_IFACE_SIMPLE_PRESENCE + '/presence' > +ATTR_SUBSCRIBE = CONN_IFACE_CONTACT_LIST + '/subscribe' > +ATTR_PUBLISH = CONN_IFACE_CONTACT_LIST + '/publish' > +ATTR_GROUPS = CONN_IFACE_CONTACT_GROUPS + '/groups' Did you add those to Gabble?
Comment on attachment 86389 [details] [review] 10/16] haze_contact_list_set_contact_groups_async: fix sense of test Review of attachment 86389 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86390 [details] [review] 11/16] roster/groups.py: convert to ContactGroups Review of attachment 86390 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86391 [details] [review] 12/16] roster/publish.py: convert to ContactList Review of attachment 86391 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86392 [details] [review] 13/16] roster/subscribe.py: convert to ContactList, ContactGroups Review of attachment 86392 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86393 [details] [review] 14/16] roster/remove-from-rp-subscribe.py: convert to Conn.I.ContactList Review of attachment 86393 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86394 [details] [review] 15/16] Remove unused function close_all_groups() Review of attachment 86394 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 86395 [details] [review] 16/16] tests: stop calling RequestChannel Review of attachment 86395 [details] [review]: ----------------------------------------------------------------- ++
(In reply to comment #26) > ::: tests/twisted/constants.py > @@ +188,5 @@ > > ATTR_CONTACT_CAPABILITIES = CONN_IFACE_CONTACT_CAPS + '/capabilities' > > ATTR_PRESENCE = CONN_IFACE_SIMPLE_PRESENCE + '/presence' > > +ATTR_SUBSCRIBE = CONN_IFACE_CONTACT_LIST + '/subscribe' > > +ATTR_PUBLISH = CONN_IFACE_CONTACT_LIST + '/publish' > > +ATTR_GROUPS = CONN_IFACE_CONTACT_GROUPS + '/groups' > > Did you add those to Gabble? Not yet, but I will.
(In reply to comment #27) > 10/16] haze_contact_list_set_contact_groups_async: fix sense of test Fixed in git for 0.7.2 (or 0.8.0)
Everything else fixed in git for 0.9.0.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.