Bug 49593 - stop Haze using deprecated things
Summary: stop Haze using deprecated things
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks: tp-glib-1.0
  Show dependency tree / graph
 
Reported: 2012-05-07 10:25 UTC by Simon McVittie
Modified: 2012-05-07 11:16 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
[tp-glib master] Include channel-iface.h in telepathy-glib.h (931 bytes, patch)
2012-05-07 10:26 UTC, Simon McVittie 		Details | Splinter Review
[Haze master, 1/3] Use TP_ERRORS instead of deprecated TP_ERROR (15.75 KB, patch)
2012-05-07 10:27 UTC, Simon McVittie 		Details | Splinter Review
[Haze master, 2/3] Use non-deprecated TpIntset APIs (2.24 KB, patch)
2012-05-07 10:27 UTC, Simon McVittie 		Details | Splinter Review
[Haze master, 3/3] Use non-deprecated TpMessage APIs (2.05 KB, patch)
2012-05-07 10:28 UTC, Simon McVittie 		Details | Splinter Review
[Haze next] Use meta-headers and catch up with current 'next' branch (4.64 KB, patch)
2012-05-07 10:28 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2012-05-07 10:25:40 UTC 
With the patches here, Haze can pass tests with CPPFLAGS=-DTP_DISABLE_DEPRECATED. (For the 'next' branch you still have to --disable-media, though.)
Comment 1 Simon McVittie 2012-05-07 10:26:34 UTC 
Created attachment 61151 [details] [review]
[tp-glib master] Include channel-iface.h in telepathy-glib.h

On master, this was already included via channel-factory-iface.h; on
next, that no longer works.
Comment 2 Simon McVittie 2012-05-07 10:27:06 UTC 
Created attachment 61152 [details] [review]
[Haze master, 1/3] Use TP_ERRORS instead of deprecated TP_ERROR
Comment 3 Simon McVittie 2012-05-07 10:27:25 UTC 
Created attachment 61153 [details] [review]
[Haze master, 2/3] Use non-deprecated TpIntset APIs
Comment 4 Simon McVittie 2012-05-07 10:28:06 UTC 
Created attachment 61154 [details] [review]
[Haze master, 3/3] Use non-deprecated TpMessage APIs

---

Slight duplication of some things Jonny already did on next, but the merge is easy enough.
Comment 5 Simon McVittie 2012-05-07 10:28:52 UTC 
Created attachment 61155 [details] [review]
[Haze next] Use meta-headers and catch up with current 'next' branch

---

Requires the telepathy-glib patch (Attachment #61151 [details]).
Comment 6 Jonny Lamb 2012-05-07 10:32:43 UTC 
Yes.
Comment 7 Xavier Claessens 2012-05-07 10:34:43 UTC 
Looks all good, +1
Comment 8 Simon McVittie 2012-05-07 11:16:49 UTC 
Thanks!

(In reply to comment #1)
> [tp-glib master] Include channel-iface.h in telepathy-glib.h

Fixed for 0.19.0;

(In reply to comment #2)
> [Haze master, n/3]

fixed for 0.7.0;

(In reply to comment #5)
> [Haze next] Use meta-headers and catch up with current 'next' branch

fixed for ... a version. 1.0, I suppose.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.