Bug 49594 - stop Salut using long-deprecated things
Summary: stop Salut using long-deprecated things
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: tp-glib-1.0
  Show dependency treegraph
 
Reported: 2012-05-07 10:37 UTC by Simon McVittie
Modified: 2012-05-30 05:00 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
1/3] Use TP_ERROR instead of long-deprecated TP_ERRORS (59.90 KB, patch)
2012-05-07 10:38 UTC, Simon McVittie
Details | Splinter Review
2/3] Use non-deprecated TpIntset APIs (7.12 KB, patch)
2012-05-07 10:38 UTC, Simon McVittie
Details | Splinter Review
3/3] Use non-deprecated TpMessage APIs (2.64 KB, patch)
2012-05-07 10:39 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2012-05-07 10:37:49 UTC
With the patches here, Salut can pass tests against telepathy-glib master with CPPFLAGS=-DTP_DISABLE_DEPRECATED, except that avahi/file-transfer/receive-file-ipv6.py gets stuck in select(). I'm fairly sure that's unrelated, since Salut master does the same against my system telepathy-glib 0.18.1.
Comment 1 Simon McVittie 2012-05-07 10:38:37 UTC
Created attachment 61156 [details] [review]
1/3] Use TP_ERROR instead of long-deprecated TP_ERRORS
Comment 2 Simon McVittie 2012-05-07 10:38:57 UTC
Created attachment 61157 [details] [review]
2/3] Use non-deprecated TpIntset APIs
Comment 3 Simon McVittie 2012-05-07 10:39:18 UTC
Created attachment 61158 [details] [review]
3/3] Use non-deprecated TpMessage APIs
Comment 4 Xavier Claessens 2012-05-07 11:10:41 UTC
+1
Comment 5 Xavier Claessens 2012-05-30 01:56:19 UTC
are patches applied, can we close this bug?
Comment 6 Simon McVittie 2012-05-30 05:00:38 UTC
(In reply to comment #5)
> are patches applied, can we close this bug?

Yes, fixed for 0.9.0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.