Bug 49768 - [BUG][FIX] incorrect command format in the help string of "r600-llvm-compiler" in "configure.ac"
Summary: [BUG][FIX] incorrect command format in the help string of "r600-llvm-compiler...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 18:51 UTC by Homer Hsing
Modified: 2012-05-15 16:04 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Homer Hsing 2012-05-10 18:51:01 UTC 
How to reproduce the bug:
  ./configure --help 
  You will see:
  --enable-r600-llvm-compiler
                          Enable experimental LLVM backend for graphics
                          shaders @<:default=disable]

What is the correct result:
./configure --help 
  You will see:
  --enable-r600-llvm-compiler
                          Enable experimental LLVM backend for graphics
                          shaders [default=disable]

This bug can be fixed by the patch below:

diff --git a/configure.ac b/configure.ac
index 43a7c0c..d66d893 100644
--- a/configure.ac
+++ b/configure.ac
@@ -639,7 +639,7 @@ AC_ARG_ENABLE([gallium_gbm],
 
 AC_ARG_ENABLE([r600-llvm-compiler],
     [AS_HELP_STRING([--enable-r600-llvm-compiler],
-        [Enable experimental LLVM backend for graphics shaders @<:default=disable@:>@
+        [Enable experimental LLVM backend for graphics shaders @<:@default=disable@:>
     [enable_r600_llvm="$enableval"],
     [enable_r600_llvm=no])
Comment 1 Homer Hsing 2012-05-10 18:53:09 UTC 
The patch above is truncated to 80 chars a line, wrong ... 

Correct patch is:

diff --git a/configure.ac b/configure.ac
index 43a7c0c..d66d893 100644
--- a/configure.ac
+++ b/configure.ac
@@ -639,7 +639,7 @@ AC_ARG_ENABLE([gallium_gbm],
 
 AC_ARG_ENABLE([r600-llvm-compiler],
     [AS_HELP_STRING([--enable-r600-llvm-compiler],
-        [Enable experimental LLVM backend for graphics shaders @<:default=disable@:>@])],
+        [Enable experimental LLVM backend for graphics shaders @<:@default=disable@:>@])],
     [enable_r600_llvm="$enableval"],
     [enable_r600_llvm=no])
Comment 2 Tom Stellard 2012-05-15 16:04:41 UTC 
Committed as 40507568047f5e5e044d1b5c25587f85a6f9bf53

Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.