Bug 49801 - Including individual glib headers no longer supported
Summary: Including individual glib headers no longer supported
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-11 07:13 UTC by Laurent Bigonville
Modified: 2012-05-11 07:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Laurent Bigonville 2012-05-11 07:13:06 UTC
Hi,

This bug has been reported on debian bug tracker:

Hi,


including invidiual glib headers has been deprecated for several years.

Starting with glib 2.32 it is now mandatory to include glib.h instead
of individual headers [1], or the compiler will generate an error.

With the notable exception of:
 glib/gi18n.h
 glib/gi18n-lib.h
 glib/gprintf.h
 glib/gstdio.h
Those header files are still meant to be included separately.


Development releases of 2.32 (2.31.x) are available in experimental.
During a test-rebuild telepathy-salut failed to build with the new glib [2].

Please update telepathy-salut at your earliest convenience, so once we move
the glib version from experimental to unstable, your package will remain
buildable.

Usually, simply replacing #include <glib/foo.h> with #include <glib.h>
is all that is needed (while keeping the above list of exceptions in
mind)
You can use the glib version from experimental to test if your package
builds correctly.


A simple shell script [3] has been written, that can help you
generate a patch which should fix the includes in most cases.
It's most likely not bug free and very limited, so please check the
resulting patch carefully.


Thanks!

Michael,
on behalf of the Debian GNOME team.

[1] http://git.gnome.org/browse/glib/commit/?id=7455dd370eb37ce3b0b409ff6120501f37b50569
[2] http://people.debian.org/~biebl/glib-single-include/telepathy-salut_0.6.0-1.log
[3] http://people.debian.org/~biebl/fix-glib-includes.sh
Comment 1 Simon McVittie 2012-05-11 07:35:36 UTC
Already fixed before 0.8.0, I think (Salut itself was fine, but Wocky had some bad #includes). I'll verify that and close the Debian bug if appropriate.
Comment 2 Simon McVittie 2012-05-11 07:46:26 UTC
Yes, fixed sometime before 0.8.0.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.