Bug 50085 - [next] Consider removing InspectHandles/RequestHandles
Summary: [next] Consider removing InspectHandles/RequestHandles
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/xc...
Whiteboard:
Keywords: patch
Depends on:
Blocks: tp-spec-1.0
  Show dependency treegraph
 
Reported: 2012-05-18 04:38 UTC by Xavier Claessens
Modified: 2012-06-07 07:25 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Xavier Claessens 2012-05-18 04:38:35 UTC
They are now useless:

For CONTACT handles, we always get handle+id pairs and we have GetContactByID, so we should never have to inspect/request a contact handle.

Other types (actually only ROOM is remaining) are used for channels. In that case again we can set TARGET_ID in channel requests, and when we receive a channel we have both handle+id in its immutable properties.

So I see no use-case for InspectHandles/RequestHandles. Removing them is also a step forward to remove handles completely, even if we are still far from that.
Comment 1 Jonny Lamb 2012-06-07 07:02:33 UTC
Ah let's just do this.

+ SHOULD return the same thing that would be returned by GetContactByID
+ on a connected <tp:dbus-ref namespace="im.telepathy1"
+ >Connection</tp:dbus-ref>.</p>

tp:dbus-ref the GetContactByID please.

+ <p>The normalized contact's identifier. Not necessarily the same string
+ as passed to GetContactByID. As a special case,

Same thing.
Comment 2 Xavier Claessens 2012-06-07 07:24:31 UTC
fixed and merged. thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.