Bug 50153 - colord-sane: only install the systemd file when installing colord-sane
Summary: colord-sane: only install the systemd file when installing colord-sane
Status: RESOLVED FIXED
Alias: None
Product: colord
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-20 12:36 UTC by Christoph Brill
Modified: 2012-05-22 04:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
colord-0.1.18-dont-install-service.patch (803 bytes, patch)
2012-05-20 12:36 UTC, Christoph Brill 		Details | Splinter Review
colord-0.1.18-disable-sane.patch (703 bytes, patch)
2012-05-20 12:43 UTC, Christoph Brill 		Details | Splinter Review
View All

Description Christoph Brill 2012-05-20 12:36:27 UTC 
Created attachment 61894 [details] [review]
colord-0.1.18-dont-install-service.patch

Right now colord-sane.service is installed if systemd is used. It also needs to be checked if the binary was actually built. The attached patch fixes that.
Comment 1 Christoph Brill 2012-05-20 12:43:29 UTC 
Created attachment 61895 [details] [review]
colord-0.1.18-disable-sane.patch

I thought about the whole Makefile a bit more. If the user does not want sane to be installed, we don't need to do anything in the Makefile. The attached patch should do exactly what I described before.
Comment 2 Richard Hughes 2012-05-21 06:00:54 UTC 
Makes sense. Do you want me to apply the second patch only?
Comment 3 Richard Hughes 2012-05-22 04:16:23 UTC 
Comment on attachment 61895 [details] [review]
colord-0.1.18-disable-sane.patch

Review of attachment 61895 [details] [review]:
-----------------------------------------------------------------

Committed as:

commit a44ac58af394245c1363629ba9d2de6ee6936d34
Author: Christoph Brill <egore@gmx.de>
Date:   Tue May 22 12:14:37 2012 +0100

    Do not install any parts of colord-sane if --disable-sane is specified
    
    Signed-off-by: Richard Hughes <richard@hughsie.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.