Bug 50484 - Mesa build fails if no `indent` available
Summary: Mesa build fails if no `indent` available
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: Other Linux (All)
: medium normal
Assignee: Kenneth Graunke
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 21:15 UTC by ojab
Modified: 2012-05-30 18:19 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description ojab 2012-05-29 21:15:43 UTC
There is no `indent` installed in my system and mesa build fails with:

python -t -O -O glX_proto_send.py -m proto | indent -i4 -nut -br -brs -npcs -ce -T GLubyte -T GLbyte -T Bool > ../../../../src/glx/indirect.c
/bin/sh: indent: command not found
Traceback (most recent call last):
  File "glX_proto_send.py", line 1097, in <module>
    printer.Print( api )
  File "/sources/mesa/src/mapi/glapi/gen/gl_XML.py", line 121, in Print
    self.printHeader()
  File "/sources/mesa/src/mapi/glapi/gen/gl_XML.py", line 141, in printHeader
    self.printRealHeader();
  File "glX_proto_send.py", line 308, in printRealHeader
    """
IOError: [Errno 32] Broken pipe
make[2]: *** [../../../../src/glx/indirect.c] Error 127
make[2]: Leaving directory `/sources/mesa/src/mapi/glapi/gen'


since:

0ce0f7c0c8fa9902678af7f3ecad2541be5808d2 is the first bad commit
commit 0ce0f7c0c8fa9902678af7f3ecad2541be5808d2
Author: Eric Anholt <eric@anholt.net>
Date:   Tue May 15 13:06:22 2012 -0700

    mesa: Remove the generated glapi from source control, and just build it.
    
    Mesa already always depends on python to build.  The checked in
    changes are not reviewed (because any trivial change rewrites the
    world).  We also have been pushing commits between xml change and
    regen where at-build-time xml-generated code disagrees with committed
    xml-generated code.  And worst of all, sometimes we ("I") check in
    *stale* xml-generated code.
    
    Acked-by: Ian Romanick <ian.d.romanick@intel.com>
Comment 1 Kenneth Graunke 2012-05-30 00:15:22 UTC
A proposed patch is on the mailing list:
http://lists.freedesktop.org/archives/mesa-dev/2012-May/022368.html

I'll probably commit it tomorrow if there are no objections.
Comment 2 Eric Anholt 2012-05-30 18:19:10 UTC
commit 2224fb6047dd96cbc11d7f2093319e5eb49c0b6b
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Tue May 29 16:03:05 2012 -0700

    automake: Check for 'indent' and fall back to 'cat' if not found.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.