Bug 5058 - __indirect_glInterleavedArrays does not error on negative stride value
Summary: __indirect_glInterleavedArrays does not error on negative stride value
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: GLX (show other bugs)
Version: unspecified
Hardware: All All
: high minor
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-15 12:41 UTC by Ian Romanick
Modified: 2005-11-29 16:08 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Ian Romanick 2005-11-15 12:41:33 UTC
According to the GL spec, glInterleavedArrays is supposed to generate the error
GL_INVALID_VALUE if the supplied stride value is < 0.  However,
__indirect_glInterleavedArrays happilly accepts such bogus values.
Comment 1 Ian Romanick 2005-11-15 12:56:14 UTC
I'm removing this from the 6.9/7.0 blocker list.  The behavior is wrong, but not
as wrong as I had thought.

The correct error *is* generated, however it is implicitly generated by the call
to glVertexPointer within __indirect_glInterleavedArrays.  This is wrong because
it allows GL state to be modified in an error condition.  GL functions are not
allowed to modify GL state when an error is generated except under a few
specific circumstances (e.g., when the error is GL_NO_MEMORY).
Comment 2 Ian Romanick 2005-11-30 11:08:05 UTC
I have committed attachment #3807 [details] [review] to both Mesa HEAD and the 6.4 branch. 
Resolving bug as FIXED.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.