Bug 506 - Bug in xf86Elo.c
Summary: Bug in xf86Elo.c
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/other (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
Depends on:
Reported: 2004-04-20 02:52 UTC by Miroslav Halas
Modified: 2004-09-21 05:01 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Fixed xf86Elo.c against xfree86 version 1.17 (51.85 KB, patch)
2004-04-20 02:52 UTC, Miroslav Halas
no flags Details | Splinter Review
Patch using diif -u against head of xf86elo.c in x.org (3.39 KB, patch)
2004-04-20 17:13 UTC, Miroslav Halas
no flags Details | Splinter Review

Description Miroslav Halas 2004-04-20 02:52:13 UTC
This bug is copy of xfree86 bug #1347 since I believe it exists in both trees
and I want to get my fix merged into both distributions.

I have two elographics touchscreens connected to Matrox G450 running
Fedora Core 1 (whatever version of XFree86 it is using). I have 
problem that the cursor doesn't correctly follow the touch, that is 
when I tap in the second touchscreen than where the cursor is 
currently, it doesn't go there. I have to keep my finger on the 
touchscreen and eventually the cursor goes to the correct 
touchscreen. Once it is in correct touchscreen everything works just 

I poke around the code in xf86Elo.c and it seems like the call to
xf86XInputSetScreen doesn't get executed properly. THis calls is made 
in this driver in xf86EloConvert which is setup as conversion_proc.

I read the documentation for xf86XInputSetScreen in xf86XInput.c and 
it says that this method should be called in ReadInput method which 
is for this driver method xf86EloReadInput. This seems to be a potential 
problem causing the xf86XInputSetScreen to don't get executed. I have talked
about this with Tristan Van Berkom <vantr@touchtunes.com> who confirmed it. 

I have create a fix and we have tested with for period of 2-3 months on several
workstations with 2 touchscreens and everything worked fine. I have not
synchronized it against the head 1.17 and the fixed file is attached. Hope you
can include it in the distribution.
Comment 1 Miroslav Halas 2004-04-20 02:52:45 UTC
Created attachment 213 [details] [review]
Fixed xf86Elo.c against xfree86 version 1.17
Comment 2 Mike A. Harris 2004-04-20 08:17:17 UTC
Patches should be supplied in unified diff format against the current
X.org sources (not XFree86).  We can not use XFree86 sources any longer
in the X.org tree due to licensing changes in the XFree86 source tree.

Can you attach a unified diff based on the most recent version of this
source in the X.org CVS, which adds the features/fixes you would
like to see included in future X.org releases?

Thanks in advance.
Comment 3 Miroslav Halas 2004-04-20 17:13:54 UTC
Created attachment 218 [details] [review]
Patch using diif -u against head of xf86elo.c in x.org
Comment 4 Adam Jackson 2004-09-21 22:01:21 UTC
applied, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.