Bug 50835 - Deprecate FC_GLOBAL_ADVANCE
Summary: Deprecate FC_GLOBAL_ADVANCE
Status: RESOLVED FIXED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: conf (show other bugs)
Version: 2.7
Hardware: Other All
: medium normal
Assignee: Akira TAGOH
QA Contact: Behdad Esfahbod
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 07:34 UTC by Behdad Esfahbod
Modified: 2012-06-11 07:34 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Behdad Esfahbod 2012-06-07 07:34:03 UTC 
I remove the feature from FreeType over a year ago:

commit 8c82ec5b17d0cfc9b0876a2d848acc207a62a25a
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Thu Apr 21 08:21:37 2011 +0200

    Always ignore global advance.
    
    This makes FT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH redundant,
    deprecated, and ignored.  The new behavior is what every major user
    of FreeType has been requesting.  Global advance is broken in many
    CJK fonts.  Just ignoring it by default makes most sense.
    
    * src/truetype/ttdriver.c (tt_get_advances),
    src/truetype/ttgload.c (TT_Get_HMetrics, TT_Get_VMetrics,
    tt_get_metrics, compute_glyph_metrics, TT_Load_Glyph),
    src/truetype/ttgload.h: Implement it.
    
    * docs/CHANGES: Updated.
Comment 1 Akira TAGOH 2012-06-07 22:20:59 UTC 
Thanks for letting me know.

I'm not sure how many projects refers FC_GLOBAL_ADVANCE though, it may be good to keep it in fontconfig.h for a while and drop the code from fcdefault.c and fcname.c too perhaps. having said that changing _FcBaseObjectTypes causes bumping the cache version, so I suppose it would be good to do drop it when we need to change the cache format in the future.
Comment 2 Behdad Esfahbod 2012-06-08 06:47:59 UTC 
Just add a note to freetype.h?
Comment 3 Akira TAGOH 2012-06-10 19:25:27 UTC 
(In reply to comment #2)
> Just add a note to freetype.h?

guess you mean fontconfig.h.
Yeah, that can be done soon.
Comment 4 Akira TAGOH 2012-06-10 22:16:02 UTC 
okay, proposed fix is here:
http://cgit.freedesktop.org/~tagoh/fontconfig/commit/?h=bz50835
Comment 5 Behdad Esfahbod 2012-06-11 07:09:53 UTC 
LGTM.
Comment 6 Akira TAGOH 2012-06-11 07:34:24 UTC 
Okay, merged into git master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.