Bug 51032 - lock not released on error in dbus_pending_call_set_notify
Summary: lock not released on error in dbus_pending_call_set_notify
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-06-13 04:46 UTC by Dmitry
Modified: 2012-07-03 12:13 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
dbus_pending_call_set_notify: don't leave the connection locked on OOM (1.44 KB, patch)
2012-06-25 04:21 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Dmitry 2012-06-13 04:46:03 UTC 
in body of dbus_pending_call_set_notify:

CONNECTION_LOCK (pending->connection);
if (!foo(...))return FALSE;
CONNECTION_UNLOCK (pending->connection);

this is an obvious bug
Comment 1 Dmitry 2012-06-13 07:36:36 UTC 
version: 1.6
Comment 2 Simon McVittie 2012-06-13 07:59:36 UTC 
That does look suspicious.

I'd welcome a patch, if you want to get this fixed sooner (or if not, someone will get round to it eventually).
Comment 3 Simon McVittie 2012-06-25 04:21:28 UTC 
Created attachment 63430 [details] [review]
dbus_pending_call_set_notify: don't leave the connection  locked on OOM
Comment 4 Lennart Poettering 2012-06-25 07:05:43 UTC 
Looks good to me.
Comment 5 Simon McVittie 2012-07-03 12:13:19 UTC 
Fixed in 1.6.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.