Bug 51078 - Doesn't return an error from RequestContactInfo when fetching a vCard fails
Summary: Doesn't return an error from RequestContactInfo when fetching a vCard fails
Status: RESOLVED MOVED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-14 08:02 UTC by Will Thompson
Modified: 2019-12-03 19:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Will Thompson 2012-06-14 08:02:40 UTC
When I type "/whois idontexist@collabora.co.uk" into Empathy, here's what happens on the wire:

<!-- sent -->
<iq id="559270952839" to="idontexist@collabora.co.uk" type="get" xmlns="jabber:client">
	<vCard xmlns="vcard-temp"/>
</iq>

<!-- received -->
<iq from="idontexist@collabora.co.uk" id="559270952839" to="will.thompson@collabora.co.uk/Queeg" type="error" xmlns="jabber:client">
	<error type="cancel">
		<item-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
	</error>
</iq>

But dbus-monitor shows this:

method call sender=:1.146 -> dest=:1.137 serial=1744 path=/org/freedesktop/Telepathy/Connection/gabble/jabber/will_2ethompson_40collabora_2eco_2euk_2fQueeg; interface=org.freedesktop.Telepathy.Connection.Interface.ContactInfo; member=RequestContactInfo
   uint32 146
method return sender=:1.137 -> dest=:1.146 reply_serial=1744
   array [
   ]

So Gabble is returning success (with no info) rather than a failure. This is irrespective of the error returned by the server. For instance, trying a contact at a non-existent domain:

<!-- sent -->
<iq id="127336127425" to="lol@whut.example.com" type="get" xmlns="jabber:client">
	<vCard xmlns="vcard-temp"/>
</iq>

<!-- received -->
<iq from="lol@whut.example.com" id="127336127425" to="will.thompson@collabora.co.uk/Queeg" type="error" xmlns="jabber:client">
	<error type="cancel">
		<remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
		<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Server-to-server connection failed: DNS resolution failed</text>
	</error>
</iq>
Comment 1 GitLab Migration User 2019-12-03 19:57:17 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/231.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.