Bug 51192 - Missing configure option --disable-xinerama
Summary: Missing configure option --disable-xinerama
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: spicec (deprecated) (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: medium enhancement
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-18 00:39 UTC by Nikolay Orlyuk
Modified: 2012-06-19 02:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Added configure option --disable-xinerama (1.14 KB, patch)
2012-06-18 00:39 UTC, Nikolay Orlyuk
Details | Splinter Review
Added configure option --disable-xinerama (1.29 KB, patch)
2012-06-18 12:22 UTC, Nikolay Orlyuk
Details | Splinter Review

Description Nikolay Orlyuk 2012-06-18 00:39:25 UTC
Created attachment 63158 [details] [review]
Added configure option --disable-xinerama

Currently requirement libXinerama is optional and decision to depend run-time on it is made from result of pkg-config detection. That's hurts many package managers that might want to provide xinerama-less spice even that libXinerama is present on system.

To get more control over final run-time dependencies --disable-xinerama will be very useful.
Comment 1 Christophe Fergeau 2012-06-18 01:39:45 UTC
I'd prefer a tri-state switch:
* nothing specified = auto, same behaviour as the current one
* --enable-xinerama = error out if xinerama cannot be found
* --disable-xinerama = xinerama is disabled
Comment 2 Nikolay Orlyuk 2012-06-18 12:22:25 UTC
Created attachment 63190 [details] [review]
Added configure option --disable-xinerama

Changed behavior to:
* Require Xinerama in case --enable-xinerama was specified.
* Ignore presence of Xinerama in case --disable-xinerama was specified.
* Decision on using Xinerama is made by result of pkg-config check if neither --enable-xinerama was specified nor --disable-xinerama.
Comment 3 Christophe Fergeau 2012-06-19 02:58:18 UTC
Thanks this looks good, I've pushed it as 95253b0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.