Bug 5122 - font Makefile.ams broken on bsd make
Summary: font Makefile.ams broken on bsd make
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: git
Hardware: Other FreeBSD
: high normal
Assignee: Eric Anholt
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1690
  Show dependency tree / graph
 
Reported: 2005-11-22 13:06 UTC by Eric Anholt
Modified: 2005-11-23 21:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
use an appropriate automatic variable for both freebsd and gnu make (26.59 KB, patch)
2005-11-22 13:06 UTC, Eric Anholt 		alan.coopersmith: 6.9/7.0+
Details | Splinter Review
View All

Description Eric Anholt 2005-11-22 13:06:00 UTC 
The Makefile.ams for fonts are using $^ to refer to the sources they use, which
isn't available for FreeBSD's make.  $< is, though, and since we're only ever
having one source, it works fine.  Patch attached.
Comment 1 Eric Anholt 2005-11-22 13:06:30 UTC 
Created attachment 3870 [details] [review]
use an appropriate automatic variable for both freebsd and gnu make
Comment 2 Alan Coopersmith 2005-11-24 15:55:22 UTC 
Comment on attachment 3870 [details] [review]
use an appropriate automatic variable for both freebsd and gnu make

Looks good to me & works with Solaris make too.

Approved - please commit.
Comment 3 Eric Anholt 2005-11-24 16:17:54 UTC 
Committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.