Bug 51375 - Xorg doesn't set status for RRGetOutputInfo
Summary: Xorg doesn't set status for RRGetOutputInfo
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Ext/RandR (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Alan Coopersmith
QA Contact: Xorg Project Team
Depends on:
Blocks: xserver-1.13
  Show dependency treegraph
Reported: 2012-06-24 03:41 UTC by Jaroslav Šmíd
Modified: 2012-07-10 16:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Set status field in reply to RRGetOutputInfo (439 bytes, patch)
2012-06-24 03:41 UTC, Jaroslav Šmíd
no flags Details | Splinter Review

Description Jaroslav Šmíd 2012-06-24 03:41:51 UTC
Created attachment 63397 [details] [review]
Set status field in reply to RRGetOutputInfo

I was writing app for screen configuration using randr extension using xcb library and found out that "status" field for RRGetOutputInfo reply is set to a random value every time I run it. That prevents my application to work properly as it does check that field to make sure the request was successfull (server could e.g. return InvalidConfigTime if the configuration was changed in between RRGetScreenResources and RRGetOutputInfo requests).

I did some search and found out it is issue in xorg server, it doesn't set "status" field in reply to RRGetOutputInfo and garbage is returned in the field. Attaching patch to fix the problem.

I think xorg should also check the timestamps and return InvalidConfigTime in the status field if they are wrong, but it doesn't seem to do so. I will report is as different bug.
Comment 1 Alan Coopersmith 2012-07-04 16:24:25 UTC
Thanks - I've included this patch in my current patch series since I'd noticed 
the missing field as well while reworking the way the values are set:
Comment 2 Jaroslav Šmíd 2012-07-10 16:07:59 UTC
Seems fixed in commit bd6f948c41865c2c9d3fba1000bf5f7458d3afc1

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.