(It's notable that "wjt@bael (2)" shows up just fine on my roster. It's only when registering a handler for a particular JID on the porter (cf. bug 51527) that it crashes. Here's the Salut debug output and backtrace for requesting a channel to "wjt@bael (2)" in Empathy:

(telepathy-salut:1264): tp-glib/connection-DEBUG: channel_request_new: New channel request at 0x6c1010: ctype=org.freedesktop.Telepathy.Channel.Type.Text htype=1 handle=2 suppress=0
(telepathy-salut:1264): salut-DEBUG: salut_im_manager_new_channel: Requested channel for handle: 2 (wjt@bael (2))
(telepathy-salut:1264): salut-DEBUG: salut_contact_manager_get_contact: Getting contact for: wjt@bael (2)
(telepathy-salut:1264): wocky-DEBUG: wocky_meta_porter_hold: wocky-meta-porter.c:388: Porter to 'wjt@bael (2)' refcount 0 --> 1
(telepathy-salut:1264): tp-glib/connection-DEBUG: satisfy_request: completing queued request 0x6c1010 with success, channel_type=org.freedesktop.Telepathy.Channel.Type.Text, handle_type=1, handle=2, suppress_handler=0
(telepathy-salut:1264): tp-glib/connection-DEBUG: channel_request_free: Freeing channel request at 0x6c1010: ctype=org.freedesktop.Telepathy.Channel.Type.Text htype=1 handle=2 suppress=0
(telepathy-salut:1264): salut-DEBUG: salut_contact_manager_get_contact: Getting contact for: wjt@bael (2)
(telepathy-salut:1264): salut-DEBUG: salut_contact_manager_get_contact: Getting contact for: wjt@bael (2)
(telepathy-salut:1264): salut-DEBUG: salut_contact_manager_get_contact: Getting contact for: wjt@bael (2)
(telepathy-salut:1264): wocky-DEBUG: process_one_address: wocky-ll-connection-factory.c:190: connecting to 172.22.64.170 (port 5298)
(telepathy-salut:1264): tp-glib/misc-DEBUG: tp_message_to_text: Parsing part 1, type text/plain, alternative (null)
(telepathy-salut:1264): tp-glib/misc-DEBUG: tp_message_to_text: ... is text/plain
(telepathy-salut:1264): tp-glib/misc-DEBUG: tp_message_to_text: ... using its text
(telepathy-salut:1264): wocky-DEBUG: connect_to_host_cb: wocky-ll-connection-factory.c:151: made connection
(telepathy-salut:1264): wocky-DEBUG: wocky_xmpp_writer_stream_open: wocky-xmpp-writer.c:298: Writing stream opening: <?xml version='1.0' encoding='UTF-8'?>
<stream:stream xmlns='jabber:client' xmlns:stream='http://etherx.jabber.org/streams' to="wjt@bael (2)" from="wjt@queeg" version="1.0">

(telepathy-salut:1264): wocky-DEBUG: send_open_cb: wocky-ll-connector.c:408: successfully sent stream open, now waiting for other side to too
(telepathy-salut:1264): wocky-DEBUG: Parsing chunk: <?xml version="1.0" encoding="UTF-8" ?>
(telepathy-salut:1264): wocky-DEBUG: Parsing chunk: <stream:stream to="wjt@queeg" from="wjt@bael (2)" xmlns="jabber:client" xmlns:stream="http://etherx.jabber.org/streams">
(telepathy-salut:1264): wocky-DEBUG: handle_stream_open: wocky-xmpp-reader.c:431: Received stream opening: stream, prefix: stream, uri: http://etherx.jabber.org/streams
(telepathy-salut:1264): wocky-DEBUG: handle_stream_open: wocky-xmpp-reader.c:450: Stream opening attribute: to = 'wjt@queeg' (prefix: <no prefix>, uri: <no uri>)
(telepathy-salut:1264): wocky-DEBUG: handle_stream_open: wocky-xmpp-reader.c:450: Stream opening attribute: from = 'wjt@bael (2)' (prefix: <no prefix>, uri: <no uri>)
(telepathy-salut:1264): wocky-DEBUG: recv_open_cb: wocky-ll-connector.c:361: connected, sending stream features but not expecting anything back
(telepathy-salut:1264): wocky-DEBUG: _write_node_tree: Serializing tree:
* features xmlns='http://etherx.jabber.org/streams'
(telepathy-salut:1264): wocky-DEBUG: Writing xml: <stream:features/>
(telepathy-salut:1264): wocky-DEBUG: made_connection_connect_cb: wocky-meta-porter.c:953: connected
**
wocky:ERROR:wocky-c2s-porter.c:212:stanza_handler_new: assertion failed: (from_valid)
[New Thread 0x7ffff1ef5700 (LWP 1285)]
[New Thread 0x7ffff16f4700 (LWP 1286)]

Program received signal SIGABRT, Aborted.

#0  0x00007ffff4755475 in *__GI_raise (sig=<optimized out>)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#1  0x00007ffff47586f0 in *__GI_abort () at abort.c:92
#2  0x00007ffff5150317 in g_assertion_message (
    domain=domain@entry=0x7ffff6d7b09b "wocky", 
    file=file@entry=0x7ffff6d7b90d "wocky-c2s-porter.c", line=line@entry=212, 
    func=func@entry=0x7ffff6d7c8f0 "stanza_handler_new", message=<optimized out>)
    at /tmp/buildd/glib2.0-2.32.3/./glib/gtestutils.c:1861
#3  0x00007ffff5150834 in g_assertion_message_expr (domain=0x7ffff6d7b09b "wocky", 
    file=0x7ffff6d7b90d "wocky-c2s-porter.c", line=212, 
    func=0x7ffff6d7c8f0 "stanza_handler_new", expr=<optimized out>)
    at /tmp/buildd/glib2.0-2.32.3/./glib/gtestutils.c:1872
#4  0x00007ffff6d483ae in ?? ()
   from /usr/lib/telepathy/salut-0/lib/libwocky-telepathy-salut-0.8.0.so
#5  0x00007ffff6d49a68 in ?? ()
   from /usr/lib/telepathy/salut-0/lib/libwocky-telepathy-salut-0.8.0.so
#6  0x00007ffff6d590a6 in ?? ()
   from /usr/lib/telepathy/salut-0/lib/libwocky-telepathy-salut-0.8.0.so
#7  0x00007ffff6d59e44 in ?? ()
   from /usr/lib/telepathy/salut-0/lib/libwocky-telepathy-salut-0.8.0.so
#8  0x00007ffff6d59f78 in ?? ()
   from /usr/lib/telepathy/salut-0/lib/libwocky-telepathy-salut-0.8.0.so
#9  0x00007ffff569c3f7 in g_simple_async_result_complete (simple=0x725e30)
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsimpleasyncresult.c:767
#10 0x00007ffff6d57381 in ?? ()
   from /usr/lib/telepathy/salut-0/lib/libwocky-telepathy-salut-0.8.0.so
#11 0x00007ffff569c3f7 in g_simple_async_result_complete (simple=0x725ea0)
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsimpleasyncresult.c:767
#12 0x00007ffff6d726ee in ?? ()
   from /usr/lib/telepathy/salut-0/lib/libwocky-telepathy-salut-0.8.0.so
#13 0x00007ffff5696089 in async_ready_callback_wrapper (source_object=0x725f10, 
    res=0x725ce0, user_data=0x734890)
    at /tmp/buildd/glib2.0-2.32.3/./gio/goutputstream.c:595
#14 0x00007ffff569c3f7 in g_simple_async_result_complete (simple=0x725ce0)
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsimpleasyncresult.c:767
#15 0x00007ffff56a75ce in g_socket_output_stream_write_ready (socket=<optimized out>, 
    condition=<optimized out>, stream=0x725f10)
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsocketoutputstream.c:170
#16 0x00007ffff569cda6 in socket_source_dispatch (source=source@entry=0x733d00, 
    callback=<optimized out>, user_data=<optimized out>)
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsocket.c:3168
#17 0x00007ffff512f205 in g_main_dispatch (context=0x6a4860)
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c:2539
#18 g_main_context_dispatch (context=context@entry=0x6a4860)
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c:3075
#19 0x00007ffff512f538 in g_main_context_iterate (context=0x6a4860, block=block@entry=1, 
    dispatch=dispatch@entry=1, 
    self=<error reading variable: Unhandled dwarf expression opcode 0xfa>)
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c:3146
#20 0x00007ffff512f932 in g_main_loop_run (loop=0x6a7650)
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c:3340
#21 0x00007ffff4e1da7f in tp_run_connection_manager (prog_name=<optimized out>, 
    version=<optimized out>, construct_cm=<optimized out>, argc=<optimized out>, 
    argv=<optimized out>) at run.c:285
#22 0x000000000041be08 in main ()

This is actually fixed by the fix for 51527: the assertion is WockyC2SPorter asserting that the JID you've told it to match is valid. In this context, “you” are the WockyMetaPorter. The fix for bug 51527 stops WockyMetaPorter telling WockyC2SPorter from matching on JIDs, so makes this bug go away.

There's a smaller bug that WockyC2SPorter should g_return_val_if_fail() from a more obvious location rather than asserting from deep inside its guts, but hey.

The bug is fixed in telepathy-salut 0.8.1.

http://cgit.collabora.com/git/user/wjt/wocky/commit/?h=porter-validate-jid-sooner moves the check to happen sooner.

(In reply to comment #3)
> http://cgit.collabora.com/git/user/wjt/wocky/commit/?h=porter-validate-jid-
> sooner moves the check to happen sooner.

Looks good to me, ship it.

http://cgit.freedesktop.org/wocky/commit?id=71d05e73c9