Bug 51593 - Add asus-nb-wmi backlight control
Summary: Add asus-nb-wmi backlight control
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Chris Wilson
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-30 06:36 UTC by Tom Hughes
Modified: 2012-07-02 02:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch to recognise asus-nb-wmi backlight interface (610 bytes, patch)
2012-06-30 06:36 UTC, Tom Hughes
no flags Details | Splinter Review

Description Tom Hughes 2012-06-30 06:36:31 UTC
Created attachment 63642 [details] [review]
Patch to recognise asus-nb-wmi backlight interface

The intel driver doesn't recognise the asus-nb-wmi backlight interface so falls back to the intel_backlight one and winds up fighting with the hotkeys which only affect the asus-nb-wmi interface.

This patch adds asus-nb-wmi to the list of recognised interfaces.
Comment 1 Chris Wilson 2012-07-02 02:27:54 UTC
I was hoping by known that we would have had a generic solution to finding the right backlight controller...

commit 61e16dc5673a1ac96b2ecee072cc3e80971be5d9
Author: Tom Hughes <tom@compton.nu>
Date:   Mon Jul 2 10:23:56 2012 +0100

    Add asus-nb-wmi backlight control
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51593

Thanks for the patch!
Comment 2 Tom Hughes 2012-07-02 02:36:08 UTC
Well one component (gnome-settings-daemon) that I investigated in the long chain between gnome-control-center and the X driver was doing a search of /sys/class/backlight and looking at the type of each one, with "firmware" taking first priority, followed by "platform" and finally "raw".

I believe that "firmware" is the manufacturer specific ones, "platform" is the generic ACPI interfaces and "raw" is the low level ones like intel_backlight which would mean that search would give basically the same results as the current hard coded list?
Comment 3 Tom Hughes 2012-07-02 02:38:05 UTC
Ah, I see you've just done that ;-)
Comment 4 Chris Wilson 2012-07-02 02:47:10 UTC
Right, the 'type' qualifier was added for libbacklight (http://cgit.freedesktop.org/libbacklight/) with which Matthew was trying to create a generic solution that with a little more help from the kernel could associate the right backlight controller for any particular output. It never quite materialized into a finished piece of code.

Indeed, I added code to scan /sys/class/backlight/*/type and pick the firmware interfaces (firmare > platform > raw) and only fallback to the known list for older kernels. Which at least should avoid the problem of detecting new controllers, but not yet addressing hybrid systems or multiple controllers.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.