Bug 51607 - Install udev rules to correct directory
Summary: Install udev rules to correct directory
Status: RESOLVED FIXED
Alias: None
Product: colord
Classification: Unclassified
Component: libcolord (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-30 14:59 UTC by Benedikt Morbach
Modified: 2012-07-02 02:05 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Get udevrulesdir from pkg-config (1.91 KB, patch)
2012-06-30 14:59 UTC, Benedikt Morbach
Details | Splinter Review
Get udevrulesdir from pkg-config (2.04 KB, patch)
2012-07-02 01:54 UTC, Benedikt Morbach
Details | Splinter Review

Description Benedikt Morbach 2012-06-30 14:59:23 UTC
Created attachment 63654 [details] [review]
Get udevrulesdir from pkg-config

udev upstream moves the rulesdir around sometimes.
Nowadays it is beneath $libdir, which even varies across distributions.

Because of this, is it kind of stupid to hardcode the path in every package.

But you can thank $deity that we have pkg-config and that udev actually provides the path to it's directory via a pkg-config variable.

So colord should use this.
Comment 1 Richard Hughes 2012-07-02 01:05:35 UTC
Patch is okay in theory, but it breaks make distcheck by:

/usr/bin/install: cannot remove `/usr/lib/udev/rules.d/69-cd-sensors.rules': Permission denied
/usr/bin/install: cannot remove `/usr/lib/udev/rules.d/95-cd-devices.rules': Permission denied

Can you integrate the "$PKG_CONFIG --variable=udevdir udev" into test $prefix or similar permissions check please, thanks.
Comment 2 Benedikt Morbach 2012-07-02 01:54:10 UTC
Created attachment 63690 [details] [review]
Get udevrulesdir from pkg-config

Like this?

kind of untested, because make distcheck fails here because of unrelated reasons.
Comment 3 Richard Hughes 2012-07-02 02:05:48 UTC
Pushed to master, thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.