Bug 51946 - remove use of pkg-config from makefiles
Summary: remove use of pkg-config from makefiles
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillScript, topicCleanup
Depends on:
Blocks:
 
Reported: 2012-07-10 13:18 UTC by David Tardon
Modified: 2015-12-16 00:19 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Tardon 2012-07-10 13:18:58 UTC 
Two gbuild makefiles--avmedia/Library_avmediagst.mk and vcl/Library_vclplug_gen.mk call pkg-config. That should be moved to configure.in .

What needs to be done:
1. extend the existing tests for gstreamer and xrender in configure.in and export _CFLAGS and _LIBS variables
2. export _CFLAGS and _LIBS variables in config_host.mk.in
3. add new externals for gstreamer and xrender to RepositoryExternal.mk
4. use gb_Library_use_externals in the makefiles and remove the pkg-config calls
Comment 1 Julien Nabet 2013-02-08 22:30:34 UTC 
David, I wouldn't know how to do this but just wonder if it's still relevant.

Indeed, I searched on Opengrok about pkg-config and found this:
http://opengrok.libreoffice.org/search?q=%22pkg-config%22&project=core&defs=&refs=&path=&hist=

At least, neither avmedia/Library_avmediagst.mk nor vcl/Library_vclplug_gen.mk seem to include it.

Can we put this to RESOLVED/FIXED?
Comment 2 David Tardon 2013-02-13 05:25:30 UTC 
Yes, we can.
Comment 3 Robinson Tryon (qubit) 2015-12-16 00:19:31 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillScript TopicCleanup)
[NinjaEdit]