When using GLES2, glGetString(GL_EXTENSIONS) advertises GL_OES_standard_derivatives but the functions added by that extension are only made available to GLSL >= 1.10, without regard to GL ES or GL.
Created attachment 64136 [details] [review] patch Add support for OES_standard_derivatives in GLSL ES Previously, we advertised the extension but the builtin functions were enabled only for GLSL and not for ES.
The patch looks good. Can you make a couple minor tweaks to the commit message and send it to the mesa-dev mailing list? Specifically, 1. Add a Signed-off-by line. 2. List the bug on its own like as: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52003 3. Add my Reviewed-by: Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Thanks!
(In reply to comment #2) > The patch looks good. Can you make a couple minor tweaks to the commit message > and send it to the mesa-dev mailing list? Specifically, > > 1. Add a Signed-off-by line. > > 2. List the bug on its own like as: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52003 > > 3. Add my Reviewed-by: > > Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> > > Thanks! Done, anything else I should do about this? http://comments.gmane.org/gmane.comp.video.mesa3d.devel/42624
(In reply to comment #3) > (In reply to comment #2) > > The patch looks good. Can you make a couple minor tweaks to the commit message > > and send it to the mesa-dev mailing list? Specifically, > > > > 1. Add a Signed-off-by line. > > > > 2. List the bug on its own like as: > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52003 > > > > 3. Add my Reviewed-by: > > > > Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> > > > > Thanks! > > Done, anything else I should do about this? > > http://comments.gmane.org/gmane.comp.video.mesa3d.devel/42624 Forgot to mention that though I have an account in fd.o, I don't have push rights in mesa's repo so I will need someone to push it for me. Thanks!
Kenneth pushed this one. Thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.