Bug 5209 - No APM or ACPI support in modular tree
Summary: No APM or ACPI support in modular tree
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: git
Hardware: Other Linux (All)
: high major
Assignee: Michel Dänzer
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: 5041
  Show dependency treegraph
 
Reported: 2005-12-02 02:23 UTC by Michel Dänzer
Modified: 2006-05-15 11:27 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Linux patch (8.79 KB, patch)
2006-04-26 19:03 UTC, Michel Dänzer
no flags Details | Splinter Review
correctly detect arch (264 bytes, patch)
2006-05-10 16:53 UTC, Valery Inozemtsev
no flags Details | Splinter Review
Include xorg-config.h in lnx_acpi.c (536 bytes, patch)
2006-05-10 19:01 UTC, Michel Dänzer
no flags Details | Splinter Review

Description Michel Dänzer 2005-12-02 02:23:26 UTC
Look for FIXME in xserver/xorg/hw/xfree86/os-support/{bsd,linux}/Makefile.am.

The lack of APM support probably breaks suspend to RAM with Apple laptops at least.
Comment 1 Michel Dänzer 2006-04-20 20:10:43 UTC
Actually, Apple laptops are fine at least with recent 2.6 kernels as those
always switch to a special VT during sleep. I assume the same is true with ACPI,
by way of either the kernel or suspend scripts. Given that and the issues with
ACPI support, that missing might be considered a feature at this point. ;)

However, this is causing real problems for APM users, see e.g.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=363120 .
Comment 2 Michel Dänzer 2006-04-26 19:03:58 UTC
Created attachment 5480 [details] [review]
Linux patch

Patch to fix this for Linux. Also removes the last traces of ACPI from the
server on platforms that don't support it.
Comment 3 Adam Jackson 2006-05-10 04:24:12 UTC
applied to 1.1 branch and head, thanks!
Comment 4 Valery Inozemtsev 2006-05-10 16:53:08 UTC
Created attachment 5592 [details] [review]
correctly detect arch
Comment 5 Valery Inozemtsev 2006-05-10 16:57:33 UTC
not build acpi for i*86. refer to correctly detect arch patch
Comment 6 Valery Inozemtsev 2006-05-10 17:57:23 UTC
ACPI as well as  not work

fragment Xorg.0.log

(**) RgbPath set to "/usr/share/X11/rgb"
(==) ModulePath set to "/usr/lib/X11/modules"
(**) Option "DontZap"
(**) Option "AllowMouseOpenFail"
(II) No APM support in BIOS or kernel
(II) Module ABI versions:
        X.Org ANSI C Emulation: 0.3
        X.Org Video Driver: 1.0
        X.Org XInput driver : 0.6
        X.Org Server Extension : 0.3
        X.Org Font Renderer : 0.5
(II) Loader running on linux
(II) LoadModule: "bitmap"

SRPMS inhere ftp://ftp.altlinux.ru/pub/people/shrek/Xorg-7.1
Comment 7 Michel Dänzer 2006-05-10 19:01:05 UTC
Created attachment 5598 [details] [review]
Include xorg-config.h in lnx_acpi.c

ACPI is disabled because lnx_acpi.c doesn't include xorg-config.h, so it
doesn't get the correct definition of xf86InfoRec.

Thanks for testing this, and sorry I couldn't test it earlier on my AMD64 box.

The arch detection patch looks good to me as well.
Comment 8 Valery Inozemtsev 2006-05-10 19:54:22 UTC
> ACPI is disabled because lnx_acpi.c doesn't include xorg-config.h, so it
> doesn't get the correct definition of xf86InfoRec.

yes, ACPI work
Please, pay your attention to #5877
Comment 9 Adam Jackson 2006-05-16 04:27:57 UTC
re-fixed, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.