Bug 5218 - segfault on startup using serial line IP
Summary: segfault on startup using serial line IP
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high critical
Assignee: Adam Jackson
QA Contact:
URL:
Whiteboard:
Keywords: patch
: 5700 5719 6347 6352 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-12-02 08:47 UTC by Andrei Barbu
Modified: 2006-05-22 05:46 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:

Attachments
fixes the bug in access.c (440 bytes, patch)
2005-12-02 08:48 UTC, Andrei Barbu 		no flags Details | Splinter Review
View All

Description Andrei Barbu 2005-12-02 08:47:42 UTC 
If you have serial line IP compiled into your kernel it creates a new network
interface. (eql)

This interface does not have an address. DefineSelf in the xorg source code
requires that network interfaces that are valid have a non-null address field.
This leads to a segfault because ConvertAddr attempts to dereference that pointer.

Adding a check to see if the ifr->ifa_addr is null fixed the bug.
Comment 1 Andrei Barbu 2005-12-02 08:48:29 UTC 
Created attachment 3968 [details] [review]
fixes the bug in access.c
Comment 2 Adam Jackson 2006-01-07 07:55:05 UTC 
actually need to check that before the decnet check, otherwise looks good to me.
Comment 3 Adam Jackson 2006-01-07 11:41:06 UTC 
applied, thanks!
Comment 4 Alan Coopersmith 2006-01-25 12:15:17 UTC 
*** Bug 5719 has been marked as a duplicate of this bug. ***
Comment 5 Alan Coopersmith 2006-01-25 12:16:11 UTC 
*** Bug 5700 has been marked as a duplicate of this bug. ***
Comment 6 Adam Jackson 2006-03-23 07:58:46 UTC 
*** Bug 6352 has been marked as a duplicate of this bug. ***
Comment 7 Adam Jackson 2006-03-23 07:59:28 UTC 
*** Bug 6347 has been marked as a duplicate of this bug. ***
Comment 8 Egmont Koblinger 2006-05-22 22:44:53 UTC 
Yes, that patch solves my problem described in a previous comment here.
Comment 9 Egmont Koblinger 2006-05-22 22:46:05 UTC 
Ouch, forget my previous post, I sent it to the wrong bug. Sorry folks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.