Bug 52606 - %-encode the "id" attribute of pkcs11 URIs
Summary: %-encode the "id" attribute of pkcs11 URIs
Status: RESOLVED FIXED
Alias: None
Product: p11-glue
Classification: Unclassified
Component: p11-kit (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Stef Walter
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 20:58 UTC by Dan Winship
Modified: 2012-07-28 08:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch (4.16 KB, patch)
2012-07-27 20:58 UTC, Dan Winship 		Details | Splinter Review
View All

Description Dan Winship 2012-07-27 20:58:34 UTC 
Created attachment 64807 [details] [review]
patch

The current draft of the pkcs11 URI spec says:

   It is recommended to percent-encode the whole value of the "id"
   attribute which is supposed to be handled as arbitrary binary data.

(Confusingly, it also says earlier "only those octets that do not correspond to characters in the unreserved set or to permitted characters from the reserved set should be percent-encoded", which should probably be fixed...)

Anyway, it looks weird to see things like

    id=b%26%8c%b0%5dx%abY4EO%e4%e0q.%cd%83yBO
Comment 1 Stef Walter 2012-07-28 08:49:31 UTC 
Comment on attachment 64807 [details] [review]
patch

Review of attachment 64807 [details] [review]:
-----------------------------------------------------------------

This looks good. Thanks. I just needed to fix the spacing (we use tabs till the indent and then spaces for wrapping), and then merged it.

BTW, if you want to request access to the p11-glue group on FDO then I'd approve the request.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.