Created attachment 64957 [details] [review] awesome patch ----------------------- BENCHMARKS ---------------------- ScalabilityBenchmark().run(iterations, events_per_iteration, 5) ORIG: [14.973108053207397, 18.12958812713623, 18.84536910057068, 25.246461153030396, 31.359580039978027, 31.669808864593506, 35.508975982666016, 34.50550079345703, 36.04320788383484, 40.6925151348114] [16.465898990631104, 18.16729497909546, 19.667570114135742, 21.99641990661621, 26.685733795166016, 31.001279830932617, 30.661032915115356, 32.82368493080139, 35.43544912338257, 43.649458169937134] NEW: [11.519503831863403, 12.892788887023926, 14.98068904876709, 18.275656938552856, 19.614477157592773, 23.503232955932617, 25.334650993347168, 28.54956817626953, 30.6826810836792, 33.6968879699707], [12.970118999481201, 15.820719957351685, 15.587357997894287, 20.564364194869995, 19.535933017730713, 22.579073190689087, 24.29000997543335, 30.67499589920044, 33.05356001853943, 36.06779193878174]
Created attachment 64958 [details] [review] forgot to commit a comment
Comment on attachment 64958 [details] [review] forgot to commit a comment Review of attachment 64958 [details] [review]: ----------------------------------------------------------------- Looking fine, just a few comments: ::: src/engine.vala @@ -79,3 @@ > for (int i = 0; i < events.length; ++i) > { > - if (events[i] != null) Why did the null check disappear? @@ +149,5 @@ > + private Database database; > + private string type; > + private GenericArray<string> data; > + > + public DataInserter (Database db, string data_type) Can we add a destructor with if (data.length > 0) warning(...)?
Created attachment 64961 [details] [review] updated patch
(Ack'd on IRC)
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.