Bug 53016 - Add "null event" handling
Summary: Add "null event" handling
Alias: None
Product: Zeitgeist
Classification: Unclassified
Component: libzeitgeist (show other bugs)
Version: 0.9.x
Hardware: Other All
: medium normal
Assignee: zeitgeist-bugs@lists.freedesktop.org
QA Contact: zeitgeist-bugs@lists.freedesktop.org
Depends on:
Reported: 2012-07-31 17:02 UTC by Siegfried-Angel Gevatter Pujals
Modified: 2014-01-02 07:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

fix (9.62 KB, patch)
2012-09-08 15:16 UTC, Siegfried-Angel Gevatter Pujals
Details | Splinter Review

Description Siegfried-Angel Gevatter Pujals 2012-07-31 17:02:31 UTC
get-events-with-id throws an exception when the id doesn't exist
Comment 1 Siegfried-Angel Gevatter Pujals 2012-09-08 15:16:52 UTC
Created attachment 66848 [details] [review]
Comment 2 Siegfried-Angel Gevatter Pujals 2012-09-08 16:23:06 UTC
Let's rather have zeitgeist_log_get_events return GenericArray, ResultSet didn't really make sense here. (GenericArray is consistent with Python, where we returna  list vs. a dictionary).

I'm keeping the iterator changes in. If we don't want those after all, it's important to note that the previous implementation had a bug (cursor being compared to events.length before increasing it).
Comment 3 Seif Lotfy 2013-01-14 14:12:08 UTC
I really would like to remove ResultSet in general and also stick to a GenericArray... This would make introspection cleaner too
Comment 4 Seif Lotfy 2014-01-02 07:02:11 UTC
This was fixed with 1543988402a80c1b70652dd73bdb60b756c6bf08

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.