Bug 53181 - Weston-DRM unlock button presented only after mousing over magic coordinates
Summary: Weston-DRM unlock button presented only after mousing over magic coordinates
Status: VERIFIED WORKSFORME
Alias: None
Product: Wayland
Classification: Unclassified
Component: weston (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 18:04 UTC by Joe Konno
Modified: 2013-06-03 15:59 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Joe Konno 2012-08-06 18:04:02 UTC
Under Weston-DRM and after screen lock, the unlock dialog appears only after mousing over the now-hidden unlock dialog, or perhaps the hidden coordinates of the green "unlock" button. This can be frustrating at high resolutions-- my test resolution is hd1080.

Keystrokes and/or mousing or mouse-clicking do *eventually* present the unlock dialog in most instances, but only after an unacceptable delay of 30 secs ~ 1 minute. Mousing over the "magic" location immediately presents the unlock dialog and button.
Comment 1 Kristian Høgsberg 2012-10-29 21:01:08 UTC
Is this still an issue?
Comment 2 Joe Konno 2012-10-30 22:20:18 UTC
It is. Reproduced with Weston-DRM, invoked with ./weston -i5. Got the lock screen straight-away after it dimmed the first time. Second time, however, had to mouse like crazy, when cursor was in lower-right corner of display. Resolution was set at hd1080.
Comment 3 Joe Konno 2013-01-29 17:50:47 UTC
This is still an issue on master. It appears to be exacerbated when a graphical workload is being executed at time of screen lock, perhaps proportional to complexity of the workload.
Comment 4 Pekka Paalanen 2013-01-30 06:51:19 UTC
Looking at the title of this bug, just to be clear, is this about:
- mousing over a magic location unlocks the desktop *without* pressing the green button, or
- mousing over whatever is needed to see the green button?
You are describing the latter, but the title says the former. The former would probably be a weston-desktop-shell crash, which would be evident in the weston log, and easier to debug.

Can you observe, whether weston-screensaver gets executed or not, and does your installation have an outdated copy of the weston-screensaver binary somewhere?

There is something going on with the unlock dialog for sure, originally it used to be movable and resizeable, and I don't think it is anymore. The delay of 30 sec to 1 min would hint towards the panel clock updating, and if that indeed is related, there's some serious confusion in the code. Could you make the panel clock have seconds, so that it will update every second, and see if that makes any difference? I think there should be a weston.ini setting for it.


Does comment #2 mean that the cursor was stuck in the lower-right corner? Or just the cursor position, when the idle timeout was hit?
Comment 5 Joe Konno 2013-01-30 13:41:08 UTC
(In reply to comment #4)
> Looking at the title of this bug, just to be clear, is this about:
> - mousing over a magic location unlocks the desktop *without* pressing the
> green button

Not quite-- I'll modify the ticket title to clarify.

> - mousing over whatever is needed to see the green button?

Correct-- that what I was attempting to describe in the original filing.

> You are describing the latter, but the title says the former. The former
> would probably be a weston-desktop-shell crash, which would be evident in
> the weston log, and easier to debug.
> 
> Can you observe, whether weston-screensaver gets executed or not, and does
> your installation have an outdated copy of the weston-screensaver binary
> somewhere?

Sure, I'll address in next post.

> 
> There is something going on with the unlock dialog for sure, originally it
> used to be movable and resizeable, and I don't think it is anymore. The
> delay of 30 sec to 1 min would hint towards the panel clock updating, and if
> that indeed is related, there's some serious confusion in the code. Could
> you make the panel clock have seconds, so that it will update every second,
> and see if that makes any difference? I think there should be a weston.ini
> setting for it.
> 
> 
> Does comment #2 mean that the cursor was stuck in the lower-right corner? Or
> just the cursor position, when the idle timeout was hit?

Just the cursor, when the idle timeout was hit.
Comment 6 Joe Konno 2013-01-30 17:25:06 UTC
(In reply to comment #4)
> Can you observe, whether weston-screensaver gets executed or not, and does
> your installation have an outdated copy of the weston-screensaver binary
> somewhere?

I typically do not build weston-screensaver. For this case, I did re-build weston with the screensaver and modify weston.ini accordingly. The screensaver does indeed execute and does not crash or report anything strange. Reported issue applies when weston-screensaver is running. In fact, the issue is more pronounced with screensaver: complete rendering hang until the lock button appears.

This calls into question my mention of "magic mouse coordinates" for sure.

> 
> There is something going on with the unlock dialog for sure, originally it
> used to be movable and resizeable, and I don't think it is anymore. The
> delay of 30 sec to 1 min would hint towards the panel clock updating, and if
> that indeed is related, there's some serious confusion in the code. Could
> you make the panel clock have seconds, so that it will update every second,
> and see if that makes any difference? I think there should be a weston.ini
> setting for it.

Alas, no weston.ini config option that I could identify, so I tested with "stock" weston (updating every minute) and with locally-modified weston that has a panel displaying %H:%M:%S includes and a redraw_handler timer firing every second.

Same behavior seen for each weston build.
Comment 7 Joe Konno 2013-06-03 15:59:09 UTC
At some point between filing and the present, this bug seems to have been remedied. Closing as "worksforme."


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.