Created attachment 65211 [details] Port data source test from libzeitgeist1 All the libzeitgeist1 test cases need to be ported to zeitgeist2 (the MIME type test is already there). Starting with data source I'll attach patches. I will also include build/ API fixes I find due to writing test cases.
Created attachment 65258 [details] [review] Port event test from libzeitgeist1 Event tests. There's one case for Event.set_actor_from_info. That function is absent from zg2 and I feel it's hardly useful to add since it's but a function call. But I included uncommented API and the test case, so whoever commits may decide if it's useful.
(In reply to comment #1) > Created attachment 65258 [details] [review] [review] > Port event test from libzeitgeist1 > > Event tests. > > There's one case for Event.set_actor_from_info. That function is absent from > zg2 and I feel it's hardly useful to add since it's but a function call. But I > included uncommented API and the test case, so whoever commits may decide if > it's useful. Awesome job. How much beer do I owe you?
Created attachment 65856 [details] [review] WIP Port log test from libzeitgeist1
Can you try to keep the C tests too? So no need to port the rest to Vala....
Created attachment 65915 [details] [review] WIP Retain C test cases from libzeitgeist1 I agree it's good to keep C tests to verify the bindings. I suggest to have all ported to Vala *and* C, because it's valuable to notice any Vala API issues as well.
Created attachment 65916 [details] [review] Port monitor test from libzeitgeist1
Created attachment 65918 [details] [review] Port monitor test from libzeitgeist1
Created attachment 65921 [details] [review] Fix ambiguous "Log" class: GLib.Log is wanted here
Created attachment 65922 [details] [review] Port symbol test from libzeitgeist1 Note: I seem to get false failures here if I'm not mistaken. Please double-check when reviewing. This may need fixes in Symbol API.
(In reply to comment #9) > Created attachment 65922 [details] [review] [review] > Port symbol test from libzeitgeist1 > > Note: I seem to get false failures here if I'm not mistaken. Please > double-check when reviewing. This may need fixes in Symbol API. I mean: I get test failures, which should not be failing, there may be bugs in that Symbol code.
Comment on attachment 65258 [details] [review] Port event test from libzeitgeist1 Review of attachment 65258 [details] [review]: ----------------------------------------------------------------- Merged
So currently we ported the tests for: - datamodel (vala) - datasource (c & vala) - event (c & vala) - log (c & vala) - marshalling (vala) - monitor(c & vala) - queryoperators (vala) - mimetypes (c & vala) - symbol (c & vala) - table-lookup (vala) - timerange (c) - timestamp (c) - where-clause (vala) Seems to me we ported all libzeitgeist1 tests to libzeitgeist2 in C and in Vala we have a couple more tests :D
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.