Bug 53233 - HarfBuzz fails to compile on mingw-w64
Summary: HarfBuzz fails to compile on mingw-w64
Status: RESOLVED FIXED
Alias: None
Product: HarfBuzz
Classification: Unclassified
Component: src (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Behdad Esfahbod
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-08 08:32 UTC by Jacek Caban
Modified: 2012-08-10 15:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
fix v1.0 (537 bytes, text/plain)
2012-08-08 08:32 UTC, Jacek Caban
Details

Description Jacek Caban 2012-08-08 08:32:31 UTC
Created attachment 65266 [details]
fix v1.0

The error is:

hb-buffer-private.hh: In function 'long int hb_segment_properties_hash(const hb_segment_properties_t*)':
hb-buffer-private.hh:73:13: error: cast from 'hb_language_t {aka hb_language_impl_t*}' to 'long int' loses precision [-fpermissive]

The attached patch fixes the problem.
Comment 1 Behdad Esfahbod 2012-08-08 18:27:28 UTC
Fixed.  Thanks.  Are you considering porting wine to harfbuzz by any chance?  I'd be glad to discuss that.
Comment 2 Jacek Caban 2012-08-09 14:08:31 UTC
(In reply to comment #1)
> Fixed.  Thanks.

I saw you did even more mingw fixes, thanks!

> Are you considering porting wine to harfbuzz by any chance? 
> I'd be glad to discuss that.

I don't really know much about these parts of Wine. I've asked Aric Stewart, who is our expert in relevant parts. He said that after a quick look he was concerned about compatibility, but he'd be happy to discuss that (his email: aric -at- codeweavers.com).


BTW, we already (very) indirectly use HarfBuzz by distributing it in our mingw-based Gecko build which is used for MSHTML implementation.
Comment 3 Behdad Esfahbod 2012-08-10 15:48:26 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Fixed.  Thanks.
> 
> I saw you did even more mingw fixes, thanks!

You're welcome.  mingw is one of my routine testing platforms.  Only 32bit though, my Ubuntu doesn't seem to have the 64bit cross-compiler.


> > Are you considering porting wine to harfbuzz by any chance? 
> > I'd be glad to discuss that.
> 
> I don't really know much about these parts of Wine. I've asked Aric Stewart,
> who is our expert in relevant parts. He said that after a quick look he was
> concerned about compatibility, but he'd be happy to discuss that (his email:
> aric -at- codeweavers.com).

Cool.  I'll shot him an email.  When I looked before it may be challenging to provide a usp10 API.  Not sure about DWrite.  But for using internally it should be an improvement over what's in there right now I would expect.


> BTW, we already (very) indirectly use HarfBuzz by distributing it in our
> mingw-based Gecko build which is used for MSHTML implementation.

Interested.  I did notice that you mostly hack on MSHTML.

Cheers,


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.