Bug 53458 - SCons KeyError: 'top_srcdir':
Summary: SCons KeyError: 'top_srcdir':
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: x86-64 (AMD64) All
: medium blocker
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 20:25 UTC by Vinson Lee
Modified: 2012-08-14 12:00 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Vinson Lee 2012-08-13 20:25:32 UTC
mesa: cd4a61100da889afec96dc79b33a88b7b8049cec (master)

$ scons
scons: Reading SConscript files ...
scons: Found LLVM version 2.9
Checking for X11 (x11 xext xdamage xfixes)... yes
Checking for XCB (x11-xcb xcb-glx >= 1.8.1)... yes
Checking for XF86VIDMODE (xxf86vm)... yes
Checking for DRM (libdrm >= 2.4.24)... yes
Checking for DRM_INTEL (libdrm_intel >= 2.4.30)... yes
Checking for DRM_RADEON (libdrm_radeon >= 2.4.31)... yes
Checking for XORG (xorg-server >= 1.6.0)... yes
Checking for KMS (libkms >= 2.4.24)... no
Checking for UDEV (libudev > 150)... yes
KeyError: 'top_srcdir':
  File "SConstruct", line 144:
    duplicate = 0 # http://www.scons.org/doc/0.97/HTML/scons-user/x2261.html
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 614:
    return method(*args, **kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 551:
    return _SConscript(self.fs, *files, **subst_kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 260:
    exec _file_ in call_stack[-1].globals
  File "src/SConscript", line 7:
    SConscript('glsl/SConscript')
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 614:
    return method(*args, **kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 551:
    return _SConscript(self.fs, *files, **subst_kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 260:
    exec _file_ in call_stack[-1].globals
  File "src/glsl/SConscript", line 46:
    source_lists = env.ParseSourceList('Makefile.sources')
  File "/usr/lib/scons/SCons/Environment.py", line 222:
    return self.method(*nargs, **kwargs)
  File "scons/custom.py", line 238:
    sym_table = parser.parse(src.abspath)
  File "scons/source_list.py", line 122:
    self.line_no += self._parse_line(line)
  File "scons/source_list.py", line 108:
    self._parse_definition(line)
  File "scons/source_list.py", line 74:
    val = self._expand_value(line[op_end:].lstrip())
  File "scons/source_list.py", line 53:
    expanded += val[cur:deref_pos] + self.symbol_table[sym]


77a3efc6b907943903190b385fdf107c4acfcdca is the first bad commit
commit 77a3efc6b907943903190b385fdf107c4acfcdca
Author: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Date:   Thu Jul 19 12:30:10 2012 +1000

    build/glsl: fix location of generated files.
    
    Like in src/mesa, use GLSL_BUILDDIR/GLSL_SRCDIR to unambiguously
    distinguish between in-tree and generated files.
    
    Reviewed-by: Eric Anholt <eric@anholt.net>
    Signed-off-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>

:040000 040000 adb4f21cb3a3a8eda9e2ea0cedbcf9df5475da38 517c2ddd643e88aa526df665df49d2f19ae5c994 M	src
bisect run success
Comment 1 Jose Fonseca 2012-08-14 12:00:22 UTC
This should be fixed with

commit ea8dcfc90d5abbf699cd64be4dccd1e69fe82d75
Author: José Fonseca <jfonseca@vmware.com>
Date:   Tue Aug 14 12:18:45 2012 +0100

    scons: Populate top_srcdir and top_builddir variables when reading Makefiles.sources.
    
    This is not entirely correct, as scons doesn't put binaries in a
    "src" subdirectory, but doesn't seem to be a problem for now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.