Bugzilla – Bug 53532
packagekitd crashes when installing EULA packages
Last modified: 2012-08-18 02:41:03 UTC
Created attachment 65591 [details]
==From the downstream bugzilla==
The SIGTRAP was from pk-transaction.c:pk_transaction_run(), and the function didn't handle PK_ROLE_ENUM_ACCEPT_EULA which is supposed to be run by pk_transaction_accept_eula().
It could be a race condition that pk_transaction_list_run_idle_cb() was called right after pk_transaction_accept_eula().
Created attachment 65592 [details] [review]
patch to ignore "accept-eula" in pk-transaction-run
It looks like a bug indeed. pk_transaction_run() is used for a transaction that's been set up, and then run run against the backend. Although I'm sure your patch fixes the bug, it's a bit of a workaround; it would be better if we never called pk_transaction_run() in the first place. I'll merge your patch to git now, and I can work out a better solution with the other developers in the next few days. Thanks.