Created attachment 65767 [details] [review] use AC_LANG_PROGRAM to detect program_invocation_short_name functionnality Hi. I'm not very good at autotools but it seems there is an issue with the program_invocation_short_name detection. On OpenBSD, we don't have this but for some reason, HAVE_PROGRAM_INVOCATION_SHORT_NAME gets defined to 1 in config.h. It looks AC_LANG_SOURCE versus AC_LANG_PROGRAM related. I checked what GNUTls is doing for program_invocation_short_name and they use AC_LANG_PROGRAM in the same way as the attached patch. I can try and provide more debug output if needed, but for now AC_LANG_PROGRAM seems to do the trick for me (I'm not saying this is the _correct_ solution; I don't know :-)). Thoughts?
Created attachment 65869 [details] [review] use AC_LANG_PROGRAM to detect program_invocation_short_name functionnality (v2) Here's actually a better patch, fully synced to what gnutls uses.
What does the build failure (before applying this patch) look like?
(In reply to comment #2) > What does the build failure (before applying this patch) look like? Hi Stef. Failure was this: libtool: link: cc -o .libs/p11-kit -O2 -pipe -g -Wall -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wdeclaration-after-statement -Wformat=2 -Winit-self +-Waggregate-return -Wno-missing-format-attribute -Wmissing-include-dirs -Wundef compat.o p11-kit.o -L.libs -lp11-kit -lpthread -Wl,-rpath-link,/usr/local/lib .libs/libp11-kit.so.0.0: warning: sprintf() is often misused, please use snprintf() compat.o(.text+0x2): In function `getprogname': ../common/compat.c:56: undefined reference to `program_invocation_short_name' collect2: ld returned 1 exit status
Thanks. Merged into git master. This will be part of p11-kit 0.14 Please build and run 'make check' for p11-kit git master and make sure I applied this patch correctly. Do you have the ability test this on more than just OpenBSD?
(In reply to comment #4) > Thanks. Merged into git master. This will be part of p11-kit 0.14 > > Please build and run 'make check' for p11-kit git master and make sure I > applied this patch correctly. Do you have the ability test this on more than > just OpenBSD? Maybe I am not looking in the correct place, but I don't see anything pushed since 2012-07-31 Fix build on solaris... I will also run make check on my Arch Linux box.
I(In reply to comment #5) > (In reply to comment #4) > > Thanks. Merged into git master. This will be part of p11-kit 0.14 > > > > Please build and run 'make check' for p11-kit git master and make sure I > > applied this patch correctly. Do you have the ability test this on more than > > just OpenBSD? > > Maybe I am not looking in the correct place, but I don't see anything pushed > since 2012-07-31 Fix build on solaris... Indeed. The push had failed. It's there now.
Hi Stef. There is a small typo in configure.ac (my fault, very sorry about that) which I couldn't see on OpenBSD but now see on Linux. Note that it doesn't change the test result, just the configure output: configure: line 14789: ,: command not found Patch attached. "make check" on Arch Linux is happy :)
Created attachment 65933 [details] [review] remove bogus comma
Comment on attachment 65933 [details] [review] remove bogus comma Pushed with some other minor whitespace fixes.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.