Bug 53915 - Filter sinks call pa_sink_process_rewind() needlessly.
Filter sinks call pa_sink_process_rewind() needlessly.
Status: NEW
Product: PulseAudio
Classification: Unclassified
Component: modules
Other All
: medium normal
Assigned To: pulseaudio-bugs
Depends on:
  Show dependency treegraph
Reported: 2012-08-22 07:48 UTC by Tanu Kaskinen
Modified: 2012-08-22 07:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Note You need to log in before you can comment on or make changes to this bug.
Description Tanu Kaskinen 2012-08-22 07:48:59 UTC
Filter sinks have this in the beginning of their pop callbacks:

    /* Hmm, process any rewind request that might be queued up */
    pa_sink_process_rewind(u->sink, 0);

There should never be any rewind requests pending when the pop callback is called, so this is a useless call (pretty harmless, though). Fixing this should be trivial (just remove the calls), but I think there should be some testing done before pushing the fix, which is why I'm filing this bug instead of just fixing it.