+++ This bug was initially created as a clone of Bug #53445 +++ Ordinary shell conditionals with "if" or "case" aren't actually safe in configure.ac; it's sometimes necessary to use AS_IF, AS_CASE. Ideally, we should do that consistently across all projects.
Hijacking this bug for a trivia branch, which includes this and more.
Created attachment 80692 [details] [review] 1/7] configure.ac: consistently use AS_IF instead of if/fi
Created attachment 80693 [details] [review] 2/7] Remove GLib < 2.32 code paths --- We already depend on it (since my last git push).
Created attachment 80694 [details] [review] 3/7] Use AC_MKDIR_P instead of deprecated AM_MKDIR_P This replaces $(mkdir_p) with $(MKDIR_P) - adjust.
Created attachment 80695 [details] [review] 4/7] .gitignore: Automake 1.13 installs test-driver
Created attachment 80696 [details] [review] 5/7] Copy in run-test.sh.in from Gabble --- This assumes that the patch at <https://bugs.freedesktop.org/show_bug.cgi?id=65290#c27> is applied to Gabble first. Please review that :-)
Created attachment 80697 [details] [review] 6/7] run-test.sh.in: adapt for Idle This is mostly s/GABBLE/IDLE/, s/gabble/idle/ but I also pulled in IDLE_SSL_KEY and IDLE_SSL_CERT, and simplified the setup for various variables that we can make identical in the installed and uninstalled cases. (The installed case isn't implemented yet.)
Created attachment 80698 [details] [review] 7/7] Run tests during "make check" with run-test.sh
This distchecks successfully with Autoconf 2.69 and Automake 1.13 under Debian, FWIW.
(In reply to comment #6) > 5/7] Copy in run-test.sh.in from Gabble > This assumes that the patch at > <https://bugs.freedesktop.org/show_bug.cgi?id=65290#c27> is applied to > Gabble first ... which it has been.
Created attachment 87386 [details] [review] 1/3] Bump Autoconf dependency to 2.60 for AC_MKDIR_P --- Regression in the patches I just committed :-( In principle this should also be applied to Gabble, Haze, Salut.
Created attachment 87387 [details] [review] 2/3] configure.ac: consistently use AS_IF instead of if/fi
Created attachment 87388 [details] [review] 3/3] Remove GLib < 2.32 code paths --- We unconditionally depend on 2.32 already.
Comment on attachment 87386 [details] [review] 1/3] Bump Autoconf dependency to 2.60 for AC_MKDIR_P Review of attachment 87386 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 87387 [details] [review] 2/3] configure.ac: consistently use AS_IF instead of if/fi Review of attachment 87387 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 87388 [details] [review] 3/3] Remove GLib < 2.32 code paths Review of attachment 87388 [details] [review]: ----------------------------------------------------------------- ++
Fixed in git for 0.3.0
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.