Bug 54295 - [Bisected IVB SNB regression]Ogles2conform GLCoverage_CoverageGL.test fails
Summary: [Bisected IVB SNB regression]Ogles2conform GLCoverage_CoverageGL.test fails
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: All Linux (All)
: high major
Assignee: Ian Romanick
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-31 02:08 UTC by lu hua
Modified: 2012-09-06 01:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Proposed fix (1.57 KB, patch)
2012-08-31 22:30 UTC, Ian Romanick 		Details | Splinter Review
View All

Description lu hua 2012-08-31 02:08:31 UTC 
System Environment:
--------------------------
Arch:             x86_64
Platform:         Ivybridge
Libdrm:	(master)libdrm-2.4.39-1-g7080bfdfd9b6c5f003daaef37ae9c329f2d46a6c
Mesa:	(master)83933606596a0197e6cd1740cb439eaf055e544d
Xserver:(master)xorg-server-1.12.99.905-12-g148583d62b84832369e9df39b3e527b99ca96761
Xf86_video_intel:(master)2.20.5-23-gdeaa1cac269be03f4ec44092f70349ff466d59de
Libva:	(staging)3c9f3d7dbd0e1b53cd47ac42984e7a563853f194
Libva_intel_driver:(staging)658ba48f5586dacd051a2d99504beedea9f7a792
Kernel:	(drm-intel-next-queued) 0e0428baf7c156bc2ba8a3fd311399c1afd88f54

Bug detailed description:
-------------------------
It fails on sandybridge and ivybridge with mesa master branch.It doesn't happen on 8.0 branch.

Bisect shows:f0c99d0a6a897189dd4b66f508385eb2ecf3f76f is the first bad commit

commit f0c99d0a6a897189dd4b66f508385eb2ecf3f76f
Author:     Ian Romanick <ian.d.romanick@intel.com>
AuthorDate: Fri Jul 27 08:31:12 2012 -0700
Commit:     Ian Romanick <ian.d.romanick@intel.com>
CommitDate: Wed Aug 29 15:09:34 2012 -0700

    mesa/es: Validate glRenderbufferStorage internalFormat in Mesa code rather than the ES wrap

    v2: Add proper core-profile and GLES3 filtering.

    v3: Allow GL_RGB10_A2UI in GLES3 based on review feedback from Eric
    Anholt.

    v4: Arg.  Reject unsized RED and RG enums on GLES.  More feedback from
    Eric.

    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reproduce steps:
----------------------------
1. xinit
2. GTF -width=64 -height=64 -run=GLCoverage/CoverageGL.test
Comment 1 Ian Romanick 2012-08-31 22:30:55 UTC 
Created attachment 66425 [details] [review]
Proposed fix

Can you try this patch?
Comment 2 lu hua 2012-09-03 05:28:02 UTC 
(In reply to comment #1)
> Created attachment 66425 [details] [review] [review]
> Proposed fix
> 
> Can you try this patch?

Add this patch to the latest mesa branch(commit a96119cc8c998).This issue goes away.
Comment 3 Ian Romanick 2012-09-03 17:39:46 UTC 
Patch committed to master (51b069e) and 9.0 branch (284fe97).
Comment 4 lu hua 2012-09-06 01:55:36 UTC 
Verified. Fixed by commit 51b069e7aa81cdc8f38db71554ae3dd12ce0a6c4.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.