Bug 54643 - usbredir-0.5 fails to build due to -Werror in configure.ac
Summary: usbredir-0.5 fails to build due to -Werror in configure.ac
Status: RESOLVED NOTABUG
Alias: None
Product: Spice
Classification: Unclassified
Component: usbredir (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Hans de Goede
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 14:27 UTC by Samuli Suominen
Modified: 2012-09-08 08:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen 2012-09-07 14:27:26 UTC
Linux, GCC 4.7.1, GLIBC 2.15, x86_64

./configure output

checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking whether ln -s works... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/x86_64-pc-linux-gnu/bin/ld
checking if the linker (/usr/x86_64-pc-linux-gnu/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/x86_64-pc-linux-gnu/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... no
checking if : is a manifest tool... no
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/x86_64-pc-linux-gnu/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for native Win32... host is x86_64-unknown-linux-gnu
no
checking whether gcc supports -Wall... yes
checking whether gcc supports -Wp,-D_FORTIFY_SOURCE=2... yes
checking whether gcc supports -fstack-protector... yes
checking whether gcc supports --param=ssp-buffer-size=4... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for LIBUSB... yes
[ ... snip ... ]

and make output:

make  all-recursive
make[1]: Entering directory `/tmp/usbredir-0.5'
Making all in usbredirparser
make[2]: Entering directory `/tmp/usbredir-0.5/usbredirparser'
  CC     usbredirparser.lo
  CC     usbredirfilter.lo
  CCLD   libusbredirparser.la
make[2]: Leaving directory `/tmp/usbredir-0.5/usbredirparser'
Making all in usbredirhost
make[2]: Entering directory `/tmp/usbredir-0.5/usbredirhost'
  CC     libusbredirhost_la-usbredirhost.lo
usbredirhost.c: In function 'usbredirhost_log_data':
usbredirhost.c:937:13: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
make[2]: *** [libusbredirhost_la-usbredirhost.lo] Error 1
make[2]: Leaving directory `/tmp/usbredir-0.5/usbredirhost'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/usbredir-0.5'
make: *** [all] Error 2
Comment 1 Samuli Suominen 2012-09-07 14:28:12 UTC
Please include configure option like ./configure --enable-werror which you can use... or vice versa, what ever

Thank you,
Samuli
Comment 2 Hans de Goede 2012-09-07 15:05:21 UTC
(In reply to comment #1)
> Please include configure option like ./configure --enable-werror which you can
> use... or vice versa, what ever
> 
> Thank you,
> Samuli

configure only sets a set of default CFLAGS if you don't set any CFLAGS yourself before calling configure, this
is done to make sure that any warnings are caught during day to day development (the warning you're seeing seems to be specific to your gcc / glibc versions).

Doing:
export CFLAGS="-g -O2 -Wall"
./configure ...

Should fix your issue.


p.s.

I've fixed the (harmless) warning in upstream git master.
Comment 3 Samuli Suominen 2012-09-08 08:39:38 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Please include configure option like ./configure --enable-werror which you can
> > use... or vice versa, what ever
> > 
> > Thank you,
> > Samuli
> 
> configure only sets a set of default CFLAGS if you don't set any CFLAGS
> yourself before calling configure, this
> is done to make sure that any warnings are caught during day to day development
> (the warning you're seeing seems to be specific to your gcc / glibc versions).
> 
> Doing:
> export CFLAGS="-g -O2 -Wall"
> ./configure ...
> 
> Should fix your issue.

I find this bad and unstandard behavior. I cannot guarantee every user has CFLAGS set, having them unset is valid configuration too.

However I've worked this around by always setting CFLAGS to -Wno-error before it hits configure phase in Gentoo's package (ebuild) with a reference to this bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.