Bug 54709 - [SNB regression]Piglit spec_glsl-1.10_execution_fs-bool-less-compare-true fails
Summary: [SNB regression]Piglit spec_glsl-1.10_execution_fs-bool-less-compare-true fails
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: 9.0
Hardware: All Linux (All)
: high major
Assignee: Kenneth Graunke
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 01:25 UTC by lu hua
Modified: 2013-02-26 06:01 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description lu hua 2012-09-10 01:25:50 UTC 
System Environment:
--------------------------
Arch:        i386
Platform:    sandybridge 
Libdrm:	(master)libdrm-2.4.39-2-g92fd0ce4f659d7b0680543e9e5b96a3c7737a5f3
Mesa:	(9.0)c7775e842bec815ede6badc35dbfe4991c183e3a
Xserver:(server-1.12-branch)xorg-server-1.12.4
Xf86_video_intel:(master)2.20.6-37-g1f5d5a37e57e63fa6e5b336a4847ce4422b89044
Libva:	(master)44b03ffcdb814392a9acf025615f99a06fed63d4
Libva_intel_driver:(master)5a449f5d2608adaf29c4c052aa28687d9e80a37a
Kernel:	(drm-intel-fixes) 28dcc2d60cb570d9f549c329b2f51400553412a1

Bug detailed description:
-------------------------
It fails on sandybridge with mesa 9.0 branch. It also fails on mesa master branch.
It doesn't happen on mesa 8.0 branch.

The last known good commit:59d247c829cce0fe14957ff32221b329fde6a918
The last known bad commit: c7775e842bec815ede6badc35dbfe4991c183e3a

output:

Probe at (0,0)
  Expected: 0.000000 1.000000 0.000000 0.000000
  Observed: 1.000000 0.000000 0.000000 0.000000
PIGLIT: {'result': 'fail' }

Reproduce steps:
----------------------------
1. xinit
2. ./bin/shader_runner fs-bool-less-compare-true.shader_test -auto -fbo
Comment 1 Ian Romanick 2012-09-14 07:31:56 UTC 
Please provide commit IDs that are on the same branch.

[idr@dynamic120 master]$ git log 59d247c829cce0fe14957ff32221b329fde6a918..c7775e842bec815ede6badc35dbfe4991c183e3a | grep ^commit | wc -l
3777

This is useless.
Comment 2 Kenneth Graunke 2012-09-14 11:13:12 UTC 
This passes on Ivybridge (but not Sandybridge) which suggests that it may have something to do with the IF statements with embedded conditional modifiers that /only/ exist on Gen6.

Could be wrong, just a shot in the dark.  Need to pull out the SNB...
Comment 3 Kenneth Graunke 2012-09-16 04:27:36 UTC 
Fixed by the following patch on the mailing list:
http://lists.freedesktop.org/archives/mesa-dev/2012-September/027519.html
Comment 4 Eric Anholt 2012-11-21 18:47:33 UTC 
commit 0482998ccc205a9d29953c7a8b33f41ae3584935
Author: Eric Anholt <eric@anholt.net>
Date:   Mon Nov 12 13:13:55 2012 -0800

    i965/fs: Fix the gen6-specific if handling for 80ecb8f15b9ad7d6edc
Comment 5 lu hua 2012-11-26 02:50:05 UTC 
(In reply to comment #4)
> commit 0482998ccc205a9d29953c7a8b33f41ae3584935
> Author: Eric Anholt <eric@anholt.net>
> Date:   Mon Nov 12 13:13:55 2012 -0800
> 
>     i965/fs: Fix the gen6-specific if handling for 80ecb8f15b9ad7d6edc

Fixed on master branch. It still fails on 9.0 branch.
Comment 6 lu hua 2013-02-26 06:01:39 UTC 
Verified.Fixed on latest mesa master branch and 9.1 branch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.