Created attachment 67086 [details] Patch to fix build When build poppler with mingw64 тeed to check whether there is a winpthreads definition because it include strtok_r declaration.
mingw64 defines __MINGW32__ ?
Yes.
> When build poppler with mingw64 тeed to check whether there is a winpthreads > definition because it include strtok_r declaration. More information: strtok_r in winpthread is declared as a macro, that is why the error happens. Therefore, it is necessary to check whether the macro __WINPTHREADS_VERSION is declared. If so, it is necessary to undefine the strtok_r macro. Also, it is possible not to use the declaration/implementation of the strtok_r function provided by poppler, and use the strtok_r macro provided by winpthread. But here I'm not sure how it would be better... P.S. This error occurs only when using the MinGW compiled with '--enable-threads=posix', for example, produced as part of MinGW-builds project: https://sourceforge.net/projects/mingwbuilds/
Can someone from the developers answer me, whether this patch will be accepted, and if so, when?
7 hours and you're already complaining? You need to learn a bit of patience if you want to keep contributing to free software projects. As answer to your question it'd be better if the implementation of strtok_r in mingw was according to standards. I'll commit Alexey's patch today or tomorrow depending on how life goes, you are free to suggest a bettef implementation in a different bug if you feel like.
Commited
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.