Bug 54873 - let account storage plugins mainly deal in GVariants
Summary: let account storage plugins mainly deal in GVariants
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://cgit.freedesktop.org/~smcv/tel...
Whiteboard: r+
Keywords: patch
Depends on: 54872
Blocks: 29563 54780
  Show dependency treegraph
 
Reported: 2012-09-13 15:12 UTC by Simon McVittie
Modified: 2013-02-13 14:37 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2012-09-13 15:12:31 UTC
When we first introduced pluggable account storage, we should have written a mock accounts store D-Bus service in the regression tests, so that the tests could q.expect() the store storing the right things. This branch rectifies that omission, then uses the new plugin to test new infrastructure for passing GVariants (rather than keyfile-syntax strings) to account plugins.

The last couple of commits demonstrate that account storage plugins can alter Parameters at will, but that altering non-Parameters basically doesn't work (Bug #54780). That will be the next in the review queue.

This is part 3 of my account storage refactoring megabranch.
Comment 1 Will Thompson 2012-11-07 16:22:17 UTC
looks fine!
Comment 2 Simon McVittie 2013-02-13 14:37:33 UTC
Fixed in git for 5.15.0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.