This is part 5 of my account storage refactoring megabranch. It's probably non-critical, although beware that I haven't yet tested part 6 without this refactoring applied.
This looks okay, but it doesn't seem to improve much in and of itself: it moves the conversions to a different place. (I guess the ultimate goal is to bubble them right out so they go away entirely.)
(In reply to comment #1) > (I guess the ultimate goal is to bubble them right out so they > go away entirely.) Yes. I could try rebasing Bug #54875 to happen before this, and not merge this one until it enables something practically-useful, if you'd prefer?
Created attachment 88301 [details] [review] mcd_keyfile_set_value: implement in terms of a new mcd_keyfile_set_variant --- Not needed for Bug #54874, but provides symmetry with the one above.
Created attachment 88302 [details] [review] mcd_keyfile_escape_value: implement in terms of mcd_keyfile_escape_variant It was previously the other way round. Similarly, implement mcd_storage_coerce_variant_to_value in terms of mcd_keyfile_escape_variant. --- Also not needed for Bug #54875, but it avoids some indirection if the previous patch is applied. I've just noticed that the last patch band should actually have been part of the previous patch - not that it matters much if both are merged.
Created attachment 88303 [details] [review] mcd_keyfile_get_value: implement in terms of a new mcd_keyfile_get_variant --- This is actually the only one needed for Bug #54875. I thought I'd already attached this - please s/above/below/ in the previous comments :-)
Comment on attachment 88301 [details] [review] mcd_keyfile_set_value: implement in terms of a new mcd_keyfile_set_variant Review of attachment 88301 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 88302 [details] [review] mcd_keyfile_escape_value: implement in terms of mcd_keyfile_escape_variant Review of attachment 88302 [details] [review]: ----------------------------------------------------------------- ++
Comment on attachment 88303 [details] [review] mcd_keyfile_get_value: implement in terms of a new mcd_keyfile_get_variant Review of attachment 88303 [details] [review]: ----------------------------------------------------------------- ++
Fixed in git for 5.17.0, thanks.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.