Bug 55095 - Provide GVariant-based access to TpContact:location
Summary: Provide GVariant-based access to TpContact:location
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: 30422
  Show dependency treegraph
 
Reported: 2012-09-19 14:33 UTC by Simon McVittie
Modified: 2012-09-26 11:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
contacts test: correct comparison of locations (1.18 KB, patch)
2012-09-19 14:33 UTC, Simon McVittie
Details | Splinter Review
tp_contact_dup_location, TpContact:location-vardict: add (12.33 KB, patch)
2012-09-19 14:34 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2012-09-19 14:33:12 UTC
Clone of #30422.
Comment 1 Simon McVittie 2012-09-19 14:33:52 UTC
Created attachment 67386 [details] [review]
contacts test: correct comparison of locations

The values are GValues, not strings.

This only appeared to work by chance: struct _GValue starts with a GType,
and G_TYPE_STRING is '@', so on little-endian platforms interpreting
a GValue as a string gives { '@', 0, 0, 0 } = "@" and on big-endian
platforms it gives  { 0, 0, 0, '@' } = "".
Comment 2 Simon McVittie 2012-09-19 14:34:13 UTC
Created attachment 67387 [details] [review]
tp_contact_dup_location, TpContact:location-vardict:  add
Comment 3 Guillaume Desmottes 2012-09-26 11:28:13 UTC
Comment on attachment 67386 [details] [review]
contacts test: correct comparison of locations

Review of attachment 67386 [details] [review]:
-----------------------------------------------------------------

funny :) ++
Comment 4 Guillaume Desmottes 2012-09-26 11:29:05 UTC
Comment on attachment 67387 [details] [review]
tp_contact_dup_location, TpContact:location-vardict:  add

Review of attachment 67387 [details] [review]:
-----------------------------------------------------------------

++
Comment 5 Guillaume Desmottes 2012-09-26 11:49:57 UTC
Merged to master for 0.19.10 (or 0.20.0 depending on which one we release).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.