Created attachment 67390 [details] [review]
tp_message_dup_part: add

Created attachment 67391 [details] [review]
tp_message_set_variant: add

Comment on attachment 67390 [details] [review]
tp_message_dup_part: add

Review of attachment 67390 [details] [review]:
-----------------------------------------------------------------

::: tests/dbus/cm-message.c
@@ +96,5 @@
>        "Badger");
>  
> +  part_vardict = tp_message_dup_part (msg, 1);
> +  g_assert_cmpstr (g_variant_get_type_string (part_vardict), ==, "a{sv}");
> +  valid = g_variant_lookup (part_vardict, "content-type", "s", &s);

you have to use "&s" as type if you don't want g_value_lookup() to copy the string for you.

@@ +99,5 @@
> +  g_assert_cmpstr (g_variant_get_type_string (part_vardict), ==, "a{sv}");
> +  valid = g_variant_lookup (part_vardict, "content-type", "s", &s);
> +  g_assert (valid);
> +  g_assert_cmpstr (s, ==, "text/plain");
> +  valid = g_variant_lookup (part_vardict, "content", "s", &s);

same here.

Comment on attachment 67391 [details] [review]
tp_message_set_variant: add

Review of attachment 67391 [details] [review]:
-----------------------------------------------------------------

++

Fixed in http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=variant-msg-55096

++

Merged to master for 0.19.10 (or 0.20.0 depending on which one we release).