Created attachment 67394 [details] [review]
tp_account_channel_request_set_hints: document that  set_hint is better for g-i

Created attachment 67395 [details] [review]
tp_account_channel_request_new_vardict: add

Created attachment 67396 [details] [review]
tp_account_channel_request_dup_request,  request-vardict property: add

Created attachment 67397 [details] [review]
tp_account_manager_create_account_async: document  TpAccountRequest as an alternative

Comment on attachment 67394 [details] [review]
tp_account_channel_request_set_hints: document that  set_hint is better for g-i

Review of attachment 67394 [details] [review]:
-----------------------------------------------------------------

Shouldn't we just (skip) it ?

Comment on attachment 67395 [details] [review]
tp_account_channel_request_new_vardict: add

Review of attachment 67395 [details] [review]:
-----------------------------------------------------------------

++

Comment on attachment 67396 [details] [review]
tp_account_channel_request_dup_request,  request-vardict property: add

Review of attachment 67396 [details] [review]:
-----------------------------------------------------------------

::: telepathy-glib/account-channel-request.c
@@ +639,5 @@
> + *
> + * Returns: (transfer full): the value of
> + *  #TpAccountChannelRequest:request-vardict
> + *
> + * Since: 0.11.12

should be UNRELEASED

Comment on attachment 67397 [details] [review]
tp_account_manager_create_account_async: document  TpAccountRequest as an alternative

Review of attachment 67397 [details] [review]:
-----------------------------------------------------------------

++

(In reply to comment #5)
> tp_account_channel_request_set_hints: document that  set_hint is better for
> g-i
> 
> Shouldn't we just (skip) it ?

That'd be a g-i API break; if there are languages in which it's usable, people might be using it from those languages.

(In reply to comment #7)
> Comment on attachment 67396 [details] [review] [review]
> tp_account_channel_request_dup_request,  request-vardict property: add
> 
> Review of attachment 67396 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: telepathy-glib/account-channel-request.c
> @@ +639,5 @@
> > + *
> > + * Returns: (transfer full): the value of
> > + *  #TpAccountChannelRequest:request-vardict
> > + *
> > + * Since: 0.11.12
> 
> should be UNRELEASED

Fixed in http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=variant-chan-req-55099

++

Merged to master for 0.19.10 (or 0.20.0 depending on which one we release).