Bug 55316 - pavucontrol git non-gtk3 compilation
Summary: pavucontrol git non-gtk3 compilation
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: pavucontrol (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: medium trivial
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-25 12:24 UTC by Pete Beardmore
Modified: 2014-11-10 08:43 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
trivial patch for gtk2 spincontrol (1.03 KB, text/plain)
2012-09-25 12:24 UTC, Pete Beardmore
Details
Patch to build pavucontrol 2.0 with gtk2 (1.27 KB, patch)
2014-11-10 01:55 UTC, lameventanas
Details | Splinter Review

Description Pete Beardmore 2012-09-25 12:24:33 UTC
Created attachment 67681 [details]
trivial patch for gtk2 spincontrol

the gtkmm3 api is not backwards compatible with 2.4 for the 'Gtk::Adjustment' object brought in in the last git revision. the patch fixes it (probably poorly as i can't remember cpp coding anymore :( )
Comment 1 Tanu Kaskinen 2012-09-25 17:55:41 UTC
Would it be too much trouble to generate the patch with "git format-patch"? I wouldn't then need to write the commit message and set the author information manually. If it's too much trouble, I can do the manual work fine, that's not a big problem.

Anyway, thanks for the patch!
Comment 2 lameventanas 2014-11-10 01:55:11 UTC
Created attachment 109180 [details] [review]
Patch to build pavucontrol 2.0 with gtk2

2 years later and there has been no followup in on this bug, and the issue is present in the latest release (version 2.0).

Initially I thought this patch was never applied, but I can see it in git, so the real problem is that nobody cared to write any useful information here.

Anyway, I already wasted some time so here is a patch for people wanting to use the released 2.0 version with gtk 2.
Comment 3 Arun Raghavan 2014-11-10 07:23:29 UTC
Thanks for the updated patch. :)
Comment 4 Pete Beardmore 2014-11-10 08:43:46 UTC
Apologies. If I remember correctly, at the time I wasn't capable of working out whether my patch introduced any memory leaks or not so 'doing it properly' went on the 'the todo list' ..which I can cross off now ..heh, 'progress' ;)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.