Bug 55368 - git-version-gen: Honor GIT_DESCRIBE_FOR_BUILD environment variable
Summary: git-version-gen: Honor GIT_DESCRIBE_FOR_BUILD environment variable
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: build-system (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-26 21:06 UTC by Colin Walters
Modified: 2012-09-27 12:23 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
git-version-gen: Honor GIT_DESCRIBE_FOR_BUILD environment variable (2.21 KB, text/plain)
2012-09-26 21:06 UTC, Colin Walters
Details

Description Colin Walters 2012-09-26 21:06:40 UTC
Created attachment 67748 [details]
git-version-gen: Honor GIT_DESCRIBE_FOR_BUILD environment  variable

The GNOME-OSTree build system currently creates chroots and bind
mounts to the source tree outside the root; this means that we can't
necessarily run git inside the root, because in the case of git
submodules, the .git repository will point to outside root.

Also, error out fatally if we fail to determine the version; it
makes no sense to put UNKNOWN in e.g. the pkg-config files
since this will just cause errors later on.
---
 configure.ac    |  4 ++++
 git-version-gen | 14 ++++++++++++--
 2 files changed, 16 insertions(+), 2 deletions(-)
Comment 1 Tanu Kaskinen 2012-09-27 12:23:48 UTC
Thank you, applied now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.