Bug 55376 - Please add a configure check that 'struct file_handle' and 'name_to_handle_at' are properly defined for the target glibc
Summary: Please add a configure check that 'struct file_handle' and 'name_to_handle_at...
Status: RESOLVED NOTOURBUG
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: PowerPC Linux (All)
: medium enhancement
Assignee: systemd-bugs
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-27 07:29 UTC by Sean McGovern
Modified: 2012-10-17 12:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Sean McGovern 2012-09-27 07:29:14 UTC
Both 'struct file_handle' and 'name_to_handle_at' are currently undefined in the PowerPC port of glibc.
Comment 1 Sean McGovern 2012-09-27 07:47:39 UTC
Sorry, apparently I can't read:

hanyuu systemd-192 # egrep -n "(file_handle|name_to_handle_at)" configure.ac 
175:AC_CHECK_FUNCS([fanotify_init fanotify_mark name_to_handle_at])

and from configure.log:

configure:15421: checking for name_to_handle_at
configure:15421: powerpc-unknown-linux-gnu-gcc -std=gnu99 -o conftest -pipe -O2 -mcpu=7450 -fno-strict-aliasing  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,--sort-common conftest.c -ldl -lrt  >&5 
configure:15421: $? = 0
configure:15421: result: yes
Comment 2 Sean McGovern 2012-09-27 07:54:46 UTC
Here's the failure to build:

hanyuu systemd-192 # make
  CC       src/shared/path-util.lo
src/shared/path-util.c: In function 'path_is_mount_point':
src/shared/path-util.c:348:10: error: dereferencing pointer to incomplete type
src/shared/path-util.c:350:9: warning: implicit declaration of function 'name_to_handle_at' [-Wimplicit-function-declaration]
src/shared/path-util.c:368:10: error: dereferencing pointer to incomplete type
make: *** [src/shared/path-util.lo] Error 1
Comment 3 Lennart Poettering 2012-09-27 16:43:16 UTC
Hmm, so in ppc: is the function exported? is the function in the header files?

If it's in one but not the other, then please fix the libc for that port, we will not work around this in systemd.

Will close this bug as it looks this way. Feel free to reopen if the AC check we do in systemd really is broken.
Comment 4 Ryan S. Arnold 2012-10-17 12:54:31 UTC
This issue is currently being worked upstream in the libc-alpha mailing list:

http://sourceware.org/ml/libc-alpha/2012-10/msg00401.html


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.