Bug 55451 - pixman-mmx.c fails to compile when iwmmxt2 is enabled
Summary: pixman-mmx.c fails to compile when iwmmxt2 is enabled
Status: RESOLVED FIXED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: 0.26.x
Hardware: Other All
: medium normal
Assignee: Søren Sandmann Pedersen
QA Contact: Søren Sandmann Pedersen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-29 16:18 UTC by Daniel Drake
Modified: 2012-09-30 19:07 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Full build log (23.72 KB, text/plain)
2012-09-29 16:18 UTC, Daniel Drake 		Details
patch (554 bytes, patch)
2012-09-30 03:10 UTC, Matt Turner 		Details | Splinter Review
patch (476 bytes, patch)
2012-09-30 03:11 UTC, Matt Turner 		Details | Splinter Review
Show Obsolete (1) View All

Description Daniel Drake 2012-09-29 16:18:02 UTC 
Created attachment 67853 [details]
Full build log

Building pixman-0.26.2 fails on Fedora 18/ARMv7 with gcc-4.8:


  CC     libpixman_iwmmxt_la-pixman-mmx.lo
pixman-mmx.c:57:1: error: redefinition of '_mm_empty'
 _mm_empty (void)
 ^
In file included from pixman-mmx.c:41:0:
/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.8.0/include/mmintrin.h:47:1: note: previous definition of '_mm_empty' was here
 _mm_empty (void)
 ^
make[3]: *** [libpixman_iwmmxt_la-pixman-mmx.lo] Error 1
Comment 1 Søren Sandmann Pedersen 2012-09-30 02:11:34 UTC 
Thanks for the bug report. Looks like GCC 4.8 has added an _mm_empty() that is conflicting with pixman's own definition.
Comment 2 Matt Turner 2012-09-30 03:10:46 UTC 
Created attachment 67863 [details] [review]
patch
Comment 3 Matt Turner 2012-09-30 03:11:59 UTC 
Created attachment 67864 [details] [review]
patch
Comment 4 Søren Sandmann Pedersen 2012-09-30 17:33:43 UTC 
Looks good to me.
Comment 5 Matt Turner 2012-09-30 19:07:15 UTC 
Patch committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.