Bug 55505 - EnumStrings.LookUpByNumber regression
Summary: EnumStrings.LookUpByNumber regression
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Oliver McFadden
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 16:33 UTC by Vinson Lee
Modified: 2012-10-03 11:24 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Vinson Lee 2012-10-01 16:33:47 UTC 
$ make check
[...]
[ RUN      ] EnumStrings.LookUpByNumber
enum_strings.cpp:43: Failure
Value of: _mesa_lookup_enum_by_nr(everything[i].value)
  Actual: "GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE"
Expected: everything[i].name
Which is: "GL_COMPRESSED_RGBA_S3TC_DXT3_EXT"
enum_strings.cpp:43: Failure
Value of: _mesa_lookup_enum_by_nr(everything[i].value)
  Actual: "GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE"
Expected: everything[i].name
Which is: "GL_COMPRESSED_RGBA_S3TC_DXT5_EXT"
[  FAILED  ] EnumStrings.LookUpByNumber (1 ms)



9545d9611fd983fd63960de787dff51aedd4a7f9 is the first bad commit
commit 9545d9611fd983fd63960de787dff51aedd4a7f9
Author: Oliver McFadden <oliver.mcfadden@linux.intel.com>
Date:   Wed Sep 26 20:59:50 2012 +0300

    intel: add support for ANGLE_texture_compression_dxt.
    
    Signed-off-by: Oliver McFadden <oliver.mcfadden@linux.intel.com>
    Reviewed-by: Brian Paul <brianp@vmware.com>

:040000 040000 10f19c68e82ac368bc2f17e73e82e5c3b3b8bb54 621cdebaa9d1585bf0b36b095fd9ceeb71619beb M	src
Comment 1 Ian Romanick 2012-10-01 21:40:00 UTC 
The fix is to s/(DXT[35])_EXT/\1_ANGLE/ in that file.  Oliver, can you take this?
Comment 2 Oliver McFadden 2012-10-01 21:51:31 UTC 
(In reply to comment #1)
> The fix is to s/(DXT[35])_EXT/\1_ANGLE/ in that file.  Oliver, can you take
> this?

Yes.
Comment 3 Oliver McFadden 2012-10-01 23:43:10 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > The fix is to s/(DXT[35])_EXT/\1_ANGLE/ in that file.  Oliver, can you take
> > this?
> 
> Yes.

Patch is awaiting review on the mailing list.
Comment 4 Oliver McFadden 2012-10-03 11:24:40 UTC 
Fixed in master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.