If I install intel-gen4asm to a non-standard location (such as /tmp/inst), and configure with PKG_CONFIG_PATH set accordingly (PKG_CONFIG_PATH=/tmp/inst/lib/pkgconfig), configure will find intel-gen4asm, but the make rules that use it will attempt to invoke it without a full path, resulting in a build failure with "intel-gen4asm: command not found". (Or worse, invoking a version of intel-gen4asm other than the intended version.) The configure script should record the bin directory from the pkg-config file, and the make rules should invoke intel-gen4asm from the appropriate location.
Also, we shouldn't rebuild the gen4 asm unless explicitly enabled by the developer.
commit 4d2dba0ba70c2b217a777243e8a89f7a5c5349a9 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Sun Oct 7 10:46:19 2012 +0100 Use path for intel-gen4asm derived from pkg-config As we use pkg-config to determine whether to use intel-gen4asm, we should also use it to locate the right version of intel-gen4asm to use. This allows the user to install the assembler in a non-standard path for cross-builds and similar. Reported-by: Josh Tripplet <josh@freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55646 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk
Thanks for the fix! However... (In reply to comment #2) > Reported-by: Josh Tripplet <josh@freedesktop.org> s/pp/p/;s/t/tt/
Oh my bad! I'm sorry.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.