Bug 55690 - libxcb 1.9 fails to support Python 3
Summary: libxcb 1.9 fails to support Python 3
Status: RESOLVED FIXED
Alias: None
Product: XCB
Classification: Unclassified
Component: Library (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: xcb mailing list dummy
QA Contact: xcb mailing list dummy
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2012-10-06 10:01 UTC by Chí-Thanh Christopher Nguyễn
Modified: 2012-11-10 18:48 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
build.log (12.14 KB, text/plain)
2012-10-06 10:01 UTC, Chí-Thanh Christopher Nguyễn
Details

Description Chí-Thanh Christopher Nguyễn 2012-10-06 10:01:36 UTC
Created attachment 68150 [details]
build.log

It appears that c3deeaf714630531d693a6a902b8dabf791858b1 introduced an error when building with python-3.2

  File "/var/tmp/portage/x11-libs/libxcb-1.9/work/libxcb-1.9/src/c_client.py", line 2911
    except OSError, e:
                  ^
SyntaxError: invalid syntax

Replacing this with PEP-3110 compliant "except OSError as e" will fix this issue, but will run into the next one, introduced by ea71d7d7e3f5d8189b80747678e9ca9a417b1d37:

  File "/var/tmp/portage/x11-libs/libxcb-1.9/work/libxcb-1.9/src/c_client.py", line 2767, in _man_event
    for seename, seetype in self.doc.see.iteritems():
AttributeError: 'dict' object has no attribute 'iteritems'
Comment 1 Chí-Thanh Christopher Nguyễn 2012-10-06 20:12:48 UTC
Re: the change of summary from "build failure with python-3" to "Support Python 3": libxcb supported python-3 fine in version 1.8.
Comment 2 Josh Triplett 2012-10-06 20:18:02 UTC
(In reply to comment #1)
> Re: the change of summary from "build failure with python-3" to "Support
> Python 3": libxcb supported python-3 fine in version 1.8.

Didn't realize that.  Changed back now.
Comment 3 Uli Schlachter 2012-11-10 18:48:03 UTC
Thanks for sending patches:

commit 76a2166de9c80b35f987fdc3f3a228bafa0de94e
Author: Chí-Thanh Christopher Nguyễn <chithanh@gentoo.org>
Date:   Thu Oct 11 01:14:12 2012 +0200

    c_client.py: Fix python-3 invalid except statement
    
    Replace except statement with a PEP-3110 compliant one. This fixes a regression
    introduced by c3deeaf714630531d693a6a902b8dabf791858b1
    https://bugs.freedesktop.org/show_bug.cgi?id=55690
    
    Reviewed-by: Peter Harris <pharris@opentext.com>
    Signed-off-by: Uli Schlachter <psychon@znc.in>

commit 9db4517c87f56bb0ac82b647a08db30850ee2b04
Author: Chí-Thanh Christopher Nguyễn <chithanh@gentoo.org>
Date:   Thu Oct 11 01:14:11 2012 +0200

    c-client.py: Fix python-3 AttributeError: 'dict' object has no attribute 'iteritems'
    
    This fixes a regression introduced by ea71d7d7e3f5d8189b80747678e9ca9a417b1d37
    https://bugs.freedesktop.org/show_bug.cgi?id=55690
    
    Reviewed-by: Peter Harris <pharris@opentext.com>
    Signed-off-by: Uli Schlachter <psychon@znc.in>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.